Aidan py tests for Xeff #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaned the x eff calc to use poa_min of 400 insted of 100 to be cosistant with 63126
Colum name pytest.
This is a file used for pytests
deleted because it is not used and psm3_pytest.csv is the same file and should be used instead.
file added to do x_eff pytest
working on x_eff
Now fixes module temp
Ignore the file h5_pytest.h5 when pytests are run.
Added a test to look at the xeff calculation.
tobin-ford
approved these changes
Jun 4, 2024
|
Don't pull to main. Create new PR. |
|
@tobin-ford - I can re-open the PR and change the base. |
|
@tobin-ford - once the tests are done, you can go ahead and merge it into development. @MDKempe @AidanWesley - Please always make pull requests into development, not into main. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a pytest to do an Xeff calculation.