Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests from Xpress to HiGHS #339

Merged
merged 25 commits into from
Dec 27, 2023
Merged

Conversation

zolanaj
Copy link
Collaborator

@zolanaj zolanaj commented Dec 13, 2023

This PR migrates the test suite formerly using Xpress in test/test_with_xpress.jl to test/runtests.jl. Many of the tests that are incompatible with HiGHS due to the presence of indicator constraints have been commented out (using @test_skip leads to errors as testsets often parse results of one REopt run before populating another), and a test checking for incompatibility or infeasibility has taken their place where appropriate.

@zolanaj zolanaj requested a review from Bill-Becker December 13, 2023 18:33
@zolanaj
Copy link
Collaborator Author

zolanaj commented Dec 13, 2023

@Bill-Becker I am waiting for a queued check (mac-PR) in the workflow to complete before I can restart the canceled one (windows-push), but the changes are ready for your review (the full test suite in ubuntu is passing).

@Bill-Becker
Copy link
Collaborator

@zolanaj Could you make a .txt file in the test folder and make a list of the testsets (not each test) which were skipped and why? Also list testsets which were not skipped but the expected results changed (significantly enough to want to figure out why at some point later).

@zolanaj
Copy link
Collaborator Author

zolanaj commented Dec 16, 2023

@zolanaj Could you make a .txt file in the test folder and make a list of the testsets (not each test) which were skipped and why? Also list testsets which were not skipped but the expected results changed (significantly enough to want to figure out why at some point later).

I added this in commit 1dbf4ce

Some of the root causes have a couple options because I haven't fully dug into them.

Copy link
Collaborator

@Bill-Becker Bill-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! PR #341 is ready to accept this merge.

@zolanaj zolanaj merged commit f883c8d into develop Dec 27, 2023
4 checks passed
@zolanaj zolanaj deleted the migrate-tests-from-xpress branch December 27, 2023 17:37
adfarth pushed a commit that referenced this pull request Feb 7, 2024
indu-manogaran pushed a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants