-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tests from Xpress to HiGHS #339
Conversation
@Bill-Becker I am waiting for a queued check (mac-PR) in the workflow to complete before I can restart the canceled one (windows-push), but the changes are ready for your review (the full test suite in ubuntu is passing). |
@zolanaj Could you make a .txt file in the test folder and make a list of the testsets (not each test) which were skipped and why? Also list testsets which were not skipped but the expected results changed (significantly enough to want to figure out why at some point later). |
I added this in commit 1dbf4ce Some of the root causes have a couple options because I haven't fully dug into them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex! PR #341 is ready to accept this merge.
Migrate tests from Xpress to HiGHS
Migrate tests from Xpress to HiGHS
This PR migrates the test suite formerly using Xpress in
test/test_with_xpress.jl
totest/runtests.jl
. Many of the tests that are incompatible with HiGHS due to the presence of indicator constraints have been commented out (using@test_skip
leads to errors as testsets often parse results of one REopt run before populating another), and a test checking for incompatibility or infeasibility has taken their place where appropriate.