Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDES #406

Open
wants to merge 113 commits into
base: develop
Choose a base branch
from
Open

LDES #406

wants to merge 113 commits into from

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented May 23, 2024

No description provided.

@hdunham hdunham requested review from lixiangk1 and toddleif May 23, 2024 21:39
@@ -43,7 +43,8 @@ function add_general_storage_dispatch_constraints(m, p, b; _n="")
#Constraint (4j): Dispatch from storage is no greater than power capacity
@constraint(m, [ts in p.time_steps],
m[Symbol("dvStoragePower"*_n)][b] >= m[Symbol("dvDischargeFromStorage"*_n)][b, ts]
)
+ m[Symbol("dvStorageToGrid")][ts] # TODO: add "b" index to this decision variable
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either dvStorageToGrid should be included within dvDischargeFromStorage and subtracted out in the load balance equations, or if it's not included like you've done here then dvDischargeFromStorage needs to be renamed to dvStorageToLoad.

)

#Dispatch from electrical storage is no greater than power capacity
Copy link
Collaborator Author

@hdunham hdunham May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this constraint added? doesn't seem to do anything beyond what (4l)-alt already accomplishes since it's over time steps without grid

hdunham and others added 28 commits August 29, 2024 13:58
This reverts commit e3a7656.
…_load_plus_battery_power)"

This reverts commit c9115a5.
@hdunham hdunham marked this pull request as ready for review September 17, 2024 18:14
@hdunham hdunham requested a review from adfarth September 17, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants