-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Grid Renewable Energy Fraction #426
base: develop
Are you sure you want to change the base?
Conversation
… grid electricity serving the load and charging the batteries.
…electricity serving the load and the batteries
…n_profile() into one function
@@ -26,6 +26,27 @@ Classify the change according to the following categories: | |||
### Removed | |||
|
|||
|
|||
## gridRE-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the plan to merge #456 into this and then merge together or to merge one first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we would merge this one first if possible, because we might not get to that one until mid January. That PR would address an issue that already exists with all of the % RE calculations, whereas this one adds new RE outputs (that do also have the whole total load issue). Do you think that's an okay approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but another thought is that if there is a known issue that we aren't fixing right away I wonder if it makes sense to temporarily remove the affected total load related outputs and/or note it somewhere for users. Mid Jan is pretty soon though especially with the holidays so maybe not worth the time to do that.
m[:AnnualEleckWh] = @expression(m,p.hours_per_time_step * ( | ||
# input electric load | ||
sum(p.s.electric_load.loads_kw[ts] for ts in p.time_steps_with_grid) | ||
+ sum(p.s.electric_load.critical_loads_kw[ts] for ts in p.time_steps_without_grid) | ||
# tech electric loads | ||
# tech electric loads #TODO: Uncomment and address any double counting with AnnualHeatkWh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this something you wanted to do in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, didin't realize this was part of that. it could be a good idea to note in #456 all the places like this that need to be considered/updated. not necessarily going through and finding all of them, cause that's the work of that PR, but just listing the ones that you already identified through this PR.
Note: The calculation of the renewable energy %s does not yet properly account for the additional load from heating and cooling techs that use electricity. This was an issue prior to this PR and is being addressed in #456.
Added
Changed