Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grid Renewable Energy Fraction #426

Open
wants to merge 78 commits into
base: develop
Choose a base branch
from
Open

Add Grid Renewable Energy Fraction #426

wants to merge 78 commits into from

Conversation

adfarth
Copy link
Collaborator

@adfarth adfarth commented Jul 26, 2024

Note: The calculation of the renewable energy %s does not yet properly account for the additional load from heating and cooling techs that use electricity. This was an issue prior to this PR and is being addressed in #456.

Added

  • Added the following inputs to account for the clean or renewable energy fraction of grid-purchased electricity:
    • ElectricUtility cambium_cef_metric to utilize clean energy data from NREL's Cambium database
    • renewable_energy_fraction_series to supply a custom grid clean or renewable energy scalar or series
    • Site include_grid_renewable_fraction_in_RE_constraints - to allow user to choose whether to include grid RE in min max constraints
  • Added the following outputs:
    • ElectricUtility annual_renewable_electricity_supplied_kwh
    • Site onsite_and_grid_renewable_electricity_fraction_of_elec_load
    • Site onsite_and_grid_renewable_energy_fraction_of_elec_and_thermal_load

Changed

  • Changed name of the following inputs:
    • ElectricUtility input cambium_metric_col changed to cambium_co2_metric
  • Changed name of the following outputs:
    • ElectricUtility cambium_emissions_region changed to cambium_region
    • Site annual_renewable_electricity_kwh changed to annual_onsite_renewable_electricity_kwh
    • Site renewable_electricity_fraction changed to onsite_renewable_electricity_fraction_of_elec_load
    • Site total_renewable_energy_fraction changed to onsite_renewable_energy_fraction_of_elec_and_thermal_load
  • Changed name of function (also available as endpoint through REopt API) from cambium_emissions_profile to cambium_profile

@adfarth adfarth self-assigned this Jul 26, 2024
.gitignore Outdated Show resolved Hide resolved
src/core/electric_utility.jl Outdated Show resolved Hide resolved
src/core/electric_utility.jl Outdated Show resolved Hide resolved
src/core/electric_utility.jl Outdated Show resolved Hide resolved
src/core/electric_utility.jl Outdated Show resolved Hide resolved
src/core/electric_utility.jl Outdated Show resolved Hide resolved
src/core/reopt.jl Outdated Show resolved Hide resolved
src/core/scenario.jl Outdated Show resolved Hide resolved
src/core/scenario.jl Outdated Show resolved Hide resolved
src/core/bau_inputs.jl Outdated Show resolved Hide resolved
@@ -26,6 +26,27 @@ Classify the change according to the following categories:
### Removed


## gridRE-dev
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the plan to merge #456 into this and then merge together or to merge one first?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we would merge this one first if possible, because we might not get to that one until mid January. That PR would address an issue that already exists with all of the % RE calculations, whereas this one adds new RE outputs (that do also have the whole total load issue). Do you think that's an okay approach?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but another thought is that if there is a known issue that we aren't fixing right away I wonder if it makes sense to temporarily remove the affected total load related outputs and/or note it somewhere for users. Mid Jan is pretty soon though especially with the holidays so maybe not worth the time to do that.

m[:AnnualEleckWh] = @expression(m,p.hours_per_time_step * (
# input electric load
sum(p.s.electric_load.loads_kw[ts] for ts in p.time_steps_with_grid)
+ sum(p.s.electric_load.critical_loads_kw[ts] for ts in p.time_steps_without_grid)
# tech electric loads
# tech electric loads #TODO: Uncomment and address any double counting with AnnualHeatkWh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this something you wanted to do in this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so; we need to more holistically address the whole "total load" approach and make sure we have funding for this; @zolanaj has a separate PR for this: #456

Copy link
Collaborator

@hdunham hdunham Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, didin't realize this was part of that. it could be a good idea to note in #456 all the places like this that need to be considered/updated. not necessarily going through and finding all of them, cause that's the work of that PR, but just listing the ones that you already identified through this PR.

src/results/site.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
src/core/electric_utility.jl Show resolved Hide resolved
src/core/electric_utility.jl Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants