Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timestep issue with generator fuel cost in subhourly data #450

Closed
wants to merge 8 commits into from

Conversation

bpulluta
Copy link
Collaborator

Update Fuel Cost Calculation to Account for Time Step Duration

Changes

  • Modified the fuel cost calculation to correctly account for the time step duration.
  • Fuel costs are given per time step (e.g., per 30 minutes), not per hour.
  • To get the correct hourly cost, we need to divide the cost per time step by the number of hours in a time step: fuel_cost_per_time_step / hours_per_time_step
  • This conversion ensures we're using the correct hourly rate in our calculations.

@bpulluta bpulluta requested a review from Bill-Becker October 14, 2024 17:14
@bpulluta
Copy link
Collaborator Author

Add a test for the subhourly fuel cost

@Bill-Becker
Copy link
Collaborator

Add a test for the subhourly fuel cost

I don't see the test. Can you also see what's going on with the failing Generator tests?

@bpulluta
Copy link
Collaborator Author

Add a test for the subhourly fuel cost

I don't see the test. Can you also see what's going on with the failing Generator tests?

I just put that there as a reminder. @Bill-Becker , i did just add tests for subhourly analysis to the offgrid case

@Bill-Becker
Copy link
Collaborator

I think we can close this and this PR replaces it (I also want to avoid those updates to the Project.toml and Manifest.toml - we should not be adding HiGHS.jl to the REopt.jl dependencies.

#453

@bpulluta
Copy link
Collaborator Author

replaced PR with #453

@bpulluta bpulluta closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants