Skip to content

Add I/O for ElectricHeater, ASHPWaterHeater, and ASHPSpaceHeater #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 82 commits into from
Sep 26, 2024

Conversation

zolanaj
Copy link
Collaborator

@zolanaj zolanaj commented Jul 2, 2024

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Adds input and output models for the ElectricHeater, ASHPWaterHeater, and ASHPSpaceHeater technologies.
  • Adds attributes can_serve_space_heating, can_serve_dhw, and can_serve_process_heat to input models of heating technologies and storage systems

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)
None (defaults are set up so that all legacy heating technologies are capable of meeting all loads)

Other information:

Additional TODO's for this PR to be ready to merge:

  • update time-series COP and capacity factor inputs after they are calculated in REopt.jl
  • add tests for bad inputs to new models and process heat load

@zolanaj zolanaj changed the base branch from master to develop July 2, 2024 20:51
@Bill-Becker
Copy link
Collaborator

@zolanaj could you update the /get_ashp_defaults endpoint to accept the force_into_system parameter which then updates the defaults for sizing_factor and om_cost_per_ton?

Also, could you add the way to update defaults from Julia for sizing_factor and om_cost_per_ton, like we do for e.g. CHP defaults (using http.jl to communicate that and process_results.py to update the inputs in the db)?

@zolanaj
Copy link
Collaborator Author

zolanaj commented Sep 25, 2024

@zolanaj could you update the /get_ashp_defaults endpoint to accept the force_into_system parameter which then updates the defaults for sizing_factor and om_cost_per_ton?

Also, could you add the way to update defaults from Julia for sizing_factor and om_cost_per_ton, like we do for e.g. CHP defaults (using http.jl to communicate that and process_results.py to update the inputs in the db)?

@Bill-Becker I believe this is now in place and I'm just working on some additional tests. I updated all the default values from Julia to be consistent with what's in the CHP defaults, rather than just being restricted to sizing_factor and om_cost_per_ton.

@zolanaj zolanaj merged commit 3398529 into develop Sep 26, 2024
1 check passed
@zolanaj zolanaj deleted the add-ashp branch September 26, 2024 17:24
@rathod-b rathod-b mentioned this pull request Sep 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants