-
Notifications
You must be signed in to change notification settings - Fork 58
Add I/O for ElectricHeater, ASHPWaterHeater, and ASHPSpaceHeater #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The underlying SSL issue appears to be tied to libgit2 library being unable to read a PEM file format, and hence errors. Workaround is to use
@zolanaj could you update the /get_ashp_defaults endpoint to accept the force_into_system parameter which then updates the defaults for sizing_factor and om_cost_per_ton? Also, could you add the way to update defaults from Julia for sizing_factor and om_cost_per_ton, like we do for e.g. CHP defaults (using http.jl to communicate that and process_results.py to update the inputs in the db)? |
@Bill-Becker I believe this is now in place and I'm just working on some additional tests. I updated all the default values from Julia to be consistent with what's in the CHP defaults, rather than just being restricted to |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
can_serve_space_heating
,can_serve_dhw
, andcan_serve_process_heat
to input models of heating technologies and storage systemsDoes this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
None (defaults are set up so that all legacy heating technologies are capable of meeting all loads)
Other information:
Additional TODO's for this PR to be ready to merge: