Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updating ASHP Inputs defaults from REopt.jl #613

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Fix updating ASHP Inputs defaults from REopt.jl #613

merged 2 commits into from
Nov 15, 2024

Conversation

Bill-Becker
Copy link
Collaborator

  • There were extra input fields coming back from REopt.jl for ASHP defaults (fields that were not included in the API, such as can_serve_process_heat) and trying to update the Django models for ASHP Inputs with those, and that was causing the update to error silently (within a try except clause)
  • This PR prunes any of those extra fields that are not included in the Django model classes before updating the models

@Bill-Becker Bill-Becker merged commit aaf7896 into develop Nov 15, 2024
3 of 4 checks passed
@Bill-Becker Bill-Becker deleted the fix-ashp-defaults-update branch November 15, 2024 16:20
@Bill-Becker Bill-Becker mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Bill-Becker