Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BESS duration limit 3 #627

Merged
merged 2 commits into from
Jan 27, 2025
Merged

BESS duration limit 3 #627

merged 2 commits into from
Jan 27, 2025

Conversation

atpham88
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)

What is the current behavior?

(You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

Other information:

@atpham88 atpham88 changed the base branch from master to develop January 27, 2025 05:14
@atpham88 atpham88 requested a review from adfarth January 27, 2025 06:31
Copy link
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved--glad all tests are passing! Feel free to merge, and then I can deploy the develop branch to the development server to make sure there are no issues there

@atpham88 atpham88 merged commit cc42493 into develop Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants