Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cmake-build-extension and logic for finding rosco library path #300

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

gbarter
Copy link
Collaborator

@gbarter gbarter commented Jan 9, 2024

Description and Purpose

To further simplify the setup.py, instead of rolling our own hack for working with cmake, this switches to a library that is intended to do exactly that while playing nicely with Python. This should help with the conda installs a bit. Also, there is now logic to automatically find the libdison.x library, wherever it might have been installed. No need for every script to do that on its own.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

TODO Items General:

  • Add example/test for new feature
  • Update registry
  • Run testing

@gbarter gbarter requested a review from dzalkind January 9, 2024 18:27
@gbarter gbarter merged commit 4cdef25 into develop Jan 9, 2024
36 checks passed
@gbarter gbarter deleted the smart_lib_path branch January 9, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants