Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Intel oneAPI compilers #396

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

rthedin
Copy link
Contributor

@rthedin rthedin commented Nov 18, 2024

Description and Purpose

This PR includes a simple addition of variable type to some missing values in certain calls. The missing variable type is a warning under certain compilers, but under some Intel oneAPI, it triggers an error. This PR is equivalent to #395, but for v2.8.
Note: ROSCO 2.9 includes these fixes.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

TODO Items General:

  • Add example/test for new feature
  • Update registry
  • Run testing

TODO Items API Change:

  • Update docs with API change
  • Run update_rosco_discons.py in Test_Cases/
  • Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

@dzalkind dzalkind merged commit 225863c into NREL:v281_prep Nov 18, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants