Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROSCO_walkthrough issues #14

Open
benoitpaillard opened this issue Jun 25, 2020 · 1 comment
Open

ROSCO_walkthrough issues #14

benoitpaillard opened this issue Jun 25, 2020 · 1 comment

Comments

@benoitpaillard
Copy link

Hi all, I stumbled upon a couple of issues in the Jupyter notebook, I guess it makes sense to report them here.

lib_name = ('../ROSCO/build/libdiscon.dylib')
can be replaced by the following to take into account all OS

import glob
lib_name = glob.glob('../ROSCO/build/libdiscon*')[0]

I reckon fast_io.load_output is now called fast_io.load_FAST_out

Test_Cases/5MW_Turb_NR/5MW_Turb_NR.out and Test_Cases/5MW_Step/5MW_Step.outb do not exist with the raw repo state. It might make sens to run some of the example to create them, if this is robust enough ?

Thanks anyway for the great tool ! Looks very promising with WISDEM

@nikhar-abbas
Copy link
Collaborator

Thanks for the comments on this, that all makes perfect sense!

I'm going to leave this issue open until the next version incrementation of the ROSCO toolbox - we'll make sure to incorporate these fixes into the next update.

Nikhar

nikhar-abbas added a commit to nikhar-abbas/ROSCO_toolbox that referenced this issue Jun 29, 2021
Replace the hard-coded CMAKE_BUILD_TYPE with an optional parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants