Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate examples for testing #36

Merged
merged 7 commits into from
Feb 9, 2021
Merged

Conversation

dzalkind
Copy link
Collaborator

@dzalkind dzalkind commented Feb 9, 2021

Major Changes:

  • Examples/run_examples.py is set up to run the examples all at once
  • This testing uncovered that there was a mismatch in array length between the pitch angles in the gain scheduling and the PI gains. controller.py was updated to make the lengths consistent.

Minor Changes:

  • Outputs of examples are added to Examples/examples_out/ as pictures for quick reviewing

Testing:

  • run python Examples/run_examples.py or python -m unittest ... or pytest Examples/run_examples.py

Note: they are set up as one example in

Copy link
Collaborator

@nikhar-abbas nikhar-abbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nikhar-abbas nikhar-abbas merged commit 0e17b73 into NREL:develop Feb 9, 2021
nikhar-abbas added a commit to nikhar-abbas/ROSCO_toolbox that referenced this pull request Jun 29, 2021
* Update for readthedocs, new version

* Iterate version

* Update README.md

Co-authored-by: dzalkind <65573423+dzalkind@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants