Pysam hybrids #1584

dguittet · 2023-11-16T23:32:14Z

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
I have checked my code and corrected any misspellings

sjanzou

Cannot build on Windows with following export_config externals error

restore develop as target for develop

…m_hybrids

sjanzou

All the Projects are build on Windows - awesome!

However, the Generic PVWatts Wind FuelCell Battery Hybrid configurations are failing on Windows, looks like "generic_degradation" needs to be updated e.g. (Host Developer)

As are the PVWatts Wind FuelCell Battery configurations with missing "degradation" for FuelCell configurations, e.g. (Single Owner)

Also, the Hybrid configuration test results are changing from the patch branch

All four hybrid with Fuel Cell configurations are still failing to run.

…m_hybrids

…or hybridized inputs only

Note that hybrid configurations will have to be reevaluated for changes before merging into patch

dguittet · 2024-03-04T15:28:44Z

@sjanzou I merged in SAM_1515 but I'm still getting outputs like ui_land_area_ha for PVWatts Hybrid when I run JSON for Inputs

dguittet · 2024-03-04T15:44:12Z

@sjanzou I made this change to the codegenerator that seems to fix it: 71940c6

sjanzou · 2024-03-05T10:55:51Z

@sjanzou I made this change to the codegenerator that seems to fix it: 71940c6

Great! Thanks for fixing that!

sjanzou · 2024-03-05T11:01:57Z

Same inputs giving different financial outputs, pysam_hybrids on left and patch on right

sjanzou

We should resolve the differences in financial outputs for both ssc and SAM with the pysam_hybrids branches.

sjanzou · 2024-03-05T11:04:29Z

test_results_win64.csv

@@ -60,8 +60,8 @@ Standalone Battery,Merchant Plant,-8397703,26.6181,NA,; Warning: IRR at end of a
 Standalone Battery,Leveraged Partnership Flip,-8397703,78.2835,72.514,; Warning: IRR at end of analysis period is not a number (NaN). This can indicate that revenues are too low to cover costs, or that they are excessively high compared to costs. Warning: IRR in target year is not a number (NaN). This can indicate that revenues are too low to cover costs, or that they are excessively high compared to costs. Warning: NPV is $-3.12112e+07. A negative NPV indicates project costs are higher than revenues.
 Standalone Battery,All Equity Partnership Flip,-8397703,79.1754,72.514,; Warning: IRR at end of analysis period is not a number (NaN). This can indicate that revenues are too low to cover costs, or that they are excessively high compared to costs. Warning: IRR in target year is not a number (NaN). This can indicate that revenues are too low to cover costs, or that they are excessively high compared to costs. Warning: NPV is $-3.85976e+07. A negative NPV indicates project costs are higher than revenues.
 Standalone Battery,Sale Leaseback,-8397703,80.5079,72.514,; Warning: IRR at end of analysis period is not a number (NaN). This can indicate that revenues are too low to cover costs, or that they are excessively high compared to costs. Warning: NPV is $-4.61131e+07. A negative NPV indicates project costs are higher than revenues. Warning: NPV is $-8.70063e+07. A negative NPV indicates project costs are higher than revenues.
-ETES,Single Owner,-466572064,14.7945,7.40855,; 
-PTES,Single Owner,-197595520,18.6636,10.3676,; 
+ETES,Single Owner,-467817888,14.8003,7.39191,; 


Why are these differing? They are in the META tag for some o and m costs but are not hybridized...

It may be that these just are non-deterministic. I just ran the PTES Single Owner case off patch and got different values from both of these:

-198005504, 18.65, 10.35

sjanzou · 2024-03-05T11:05:48Z

test_results_win64.csv

-PVWatts Wind FuelCell Battery Hybrid,Single Owner,579660736,10.6946,5.41105,; Notice: Simulation time step is 60 minutes for pvwattsv8. Notice: Simulation time step is 60 minutes for windpower.
-PVWatts Wind FuelCell Battery Hybrid,Host Developer,2.68732e+06,49.7344,51.3994,; Notice: Simulation time step is 60 minutes for pvwattsv8. Notice: Simulation time step is 60 minutes for windpower.
-Photovoltaic Wind Battery Hybrid,Single Owner,594070784,8.46988,5.95228,; Notice: Simulation time step is 60 minutes for pvsamv1. Notice: Simulation time step is 60 minutes for windpower.
+PVWatts Wind Battery Hybrid,Single Owner,578883008,10.553,5.91853,; Notice: Simulation time step is 60 minutes for pvwattsv8. Notice: Simulation time step is 60 minutes for windpower.


All the hybrid financial outputs differ and so do the ssc test using the same input file as commented on ssc pull request 1091.

sjanzou

Working on windows and results matching with patch branches ssc and SAM.

Great work

dguittet added 9 commits October 6, 2023 12:12

update CSP entries for PySAM config_to_cmod_name table

d637d3b

Merge branch 'develop' into pysam_hybrids

04b781c

Merge branch 'develop' into pysam_hybrids

ba368e6

update export_config

b80b99a

Merge branch 'develop' into pysam_hybrids

84cbf5d

update pysam files

c6b4378

Merge branch 'develop' into pysam_hybrids

757d000

remove print statement

10cfc6e

fix run_defaults_diff.py

3ac496e

janinefreeman requested a review from sjanzou November 21, 2023 21:11

Fix broken config_extractor build on Windows

ec2cacf

sjanzou requested changes Nov 26, 2023

View reviewed changes

dguittet and others added 7 commits December 4, 2023 16:03

use sscapi for adding hybrid vartable

f7f3d6d

Merge branch 'develop' into pysam_hybrids

03f23da

update library

d18ad81

Merge branch 'develop' into pysam_hybrids

c099aa2

update pysam files

28258a6

Merge branch 'develop' into pysam_hybrids

946c523

update AdjustmentFactors

adde2ee

brtietz changed the base branch from develop to patch December 13, 2023 16:37

brtietz and others added 10 commits December 13, 2023 09:53

restore develop as target for develop

d4c919c

Merge pull request #1665 from NREL/patch_to_develop_w_ci

8fca322

restore develop as target for develop

Merge branch 'develop' into pysam_hybrids

89f4625

Merge branch 'adjust_api' into pysam_hybrids

fbb22b0

Update SAMapi files

0de809c

Merge branch 'pysam_hybrids' of https://github.com/NREL/SAM into pysa…

a1b6ab9

…m_hybrids

adjustment factors default to 0

91bd4c9

fix tcsmslf

3f3a86c

update pysam docs generation

6a513a2

Merge branch 'patch' into pysam_hybrids

3c68673

sjanzou requested changes Feb 19, 2024

View reviewed changes

dguittet added 2 commits February 19, 2024 08:16

update defaults maneuvering for hybrids

3cbafaf

update defaults maneuvering for hybrids

781ec2c

sjanzou mentioned this pull request Feb 20, 2024

Update for pysam hybrids NREL/ssc#1091

Merged

sjanzou and others added 12 commits February 20, 2024 02:01

Fix failing Windows build and export_config updates

ee1d735

All four hybrid with Fuel Cell configurations are still failing to run.

Merge branch 'pysam_hybrids' of https://github.com/nrel/SAM into pysa…

ce26386

…m_hybrids

update windows results

87ad92c

update export config for hybrids

db99724

Merge branch 'patch' into pysam_hybrids

2b9bc3a

Merge branch 'patch' into SAM_1515

21a1302

Limit code generation to compute module inputs only

48c6c6a

Merge branch 'patch' into pysam_hybrids

977bee6

Merge branch 'pysam_hybrids' into SAM_1515

a05b87c

Update build_C_API.cpp for C++11 in patch and update code generator f…

2723ded

…or hybridized inputs only

Update results for failing GitHub Actions.

fd397a2

Note that hybrid configurations will have to be reevaluated for changes before merging into patch

Merge branch 'SAM_1515' into pysam_hybrids

da6d81f

fix codegenerator

71940c6

dguittet and others added 3 commits March 4, 2024 08:47

Merge branch 'SAM_1515' into pysam_hybrids

da1d203

Merge branch 'patch' into pysam_hybrids

49b6106

fix codegenerator for hybrids

513ec26

sjanzou requested changes Mar 5, 2024

View reviewed changes

dguittet and others added 2 commits March 5, 2024 15:46

update test_results_win64.csv

b2d14ae

Clean and build and run on Windows

4ea27ba

sjanzou self-requested a review March 6, 2024 09:02

sjanzou approved these changes Mar 6, 2024

View reviewed changes

sjanzou merged commit 5f9f0e6 into patch Mar 6, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pysam hybrids #1584

Pysam hybrids #1584

dguittet commented Nov 16, 2023

sjanzou left a comment

sjanzou left a comment

dguittet commented Mar 4, 2024

dguittet commented Mar 4, 2024

sjanzou commented Mar 5, 2024

sjanzou commented Mar 5, 2024

sjanzou left a comment

sjanzou Mar 5, 2024

dguittet Mar 5, 2024

sjanzou Mar 5, 2024

sjanzou left a comment

Pysam hybrids #1584

Pysam hybrids #1584

Conversation

dguittet commented Nov 16, 2023

Pull Request Template

Description

Type of change

Checklist:

sjanzou left a comment

Choose a reason for hiding this comment

sjanzou left a comment

Choose a reason for hiding this comment

dguittet commented Mar 4, 2024

dguittet commented Mar 4, 2024

sjanzou commented Mar 5, 2024

sjanzou commented Mar 5, 2024

sjanzou left a comment

Choose a reason for hiding this comment

sjanzou Mar 5, 2024

Choose a reason for hiding this comment

dguittet Mar 5, 2024

Choose a reason for hiding this comment

sjanzou Mar 5, 2024

Choose a reason for hiding this comment

sjanzou left a comment

Choose a reason for hiding this comment