-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI fixes 2024 #1926
UI fixes 2024 #1926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjanzou Thanks for finding those issues. I'm finding that I need to set the height for list boxes to 28 to make the text fit on Linux. Other widgets seem to work well with height = 24. (Many currently have height = 21.) I also did a spot check to make sure these changes for Linux don't make things look bad in Windows. |
@taylorbrown75 Is it OK to delete the "Electricity Purchases Heat Model.json" file and its associated commented-out line in startup.lk? It looks like this might have been left over from an earlier iteration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on Windows and Linux. I will defer to @dguittet for MacOS UI review.
That should be okay to remove. Seems to be from before we updated the IPH financials. |
Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
Check alignment, text box sizes, etc. on Linux for all UI updates for Fall 2024.
Go over new IPH input pages and set widget Group and UIObject property.
@dguittet I'm listing you as a reviewer since it looks like you're assigned to check UI forms on Mac -- please do that check from this branch or after it is merged into Develop.