Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fixes 2024 #1926

Merged
merged 11 commits into from
Dec 9, 2024
Merged

UI fixes 2024 #1926

merged 11 commits into from
Dec 9, 2024

Conversation

cpaulgilman
Copy link
Collaborator

Check alignment, text box sizes, etc. on Linux for all UI updates for Fall 2024.

Go over new IPH input pages and set widget Group and UIObject property.

@dguittet I'm listing you as a reviewer since it looks like you're assigned to check UI forms on Mac -- please do that check from this branch or after it is merged into Develop.

@cpaulgilman cpaulgilman added this to the SAM Fall 2024 Release milestone Nov 23, 2024
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing on RHEL 8.6

Some minor issues on IPH MSLF Collector and Receiver page
image

Electricity purchases page
image

All other page updates look good!

@cpaulgilman
Copy link
Collaborator Author

@sjanzou Thanks for finding those issues. I'm finding that I need to set the height for list boxes to 28 to make the text fit on Linux. Other widgets seem to work well with height = 24. (Many currently have height = 21.)

I also did a spot check to make sure these changes for Linux don't make things look bad in Windows.

@cpaulgilman
Copy link
Collaborator Author

@taylorbrown75 Is it OK to delete the "Electricity Purchases Heat Model.json" file and its associated commented-out line in startup.lk? It looks like this might have been left over from an earlier iteration.

@sjanzou sjanzou self-requested a review November 26, 2024 06:51
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on Windows and Linux. I will defer to @dguittet for MacOS UI review.

@taylorbrown75
Copy link
Collaborator

@taylorbrown75 Is it OK to delete the "Electricity Purchases Heat Model.json" file and its associated commented-out line in startup.lk? It looks like this might have been left over from an earlier iteration.

That should be okay to remove. Seems to be from before we updated the IPH financials.

@dguittet dguittet mentioned this pull request Nov 26, 2024
@cpaulgilman cpaulgilman merged commit 137893c into develop Dec 9, 2024
8 checks passed
@cpaulgilman cpaulgilman deleted the ui-fixes-2024 branch December 9, 2024 23:54
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants