Add List Resources feature to FASTSim-2 (SerdeAPI tweaks, list_resources) #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 6, 2024 17:45
Also add unit test to confirm it works. NOTE: there are (apparently) no vehicle data files for FASTSim-2. Therefoe, the list_resources call on RustVehicle was removed.
Also add python tests to confirm results
|
@michael-okeefe , this looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fastsim-2 implementation to address this issue:
https://github.nrel.gov/MBAP/fastsim/issues/354
The resources::list_resources(subdir) will list all the resources of a given subdirectory. If the subdirectory doesn't exist, an empty vector of string is returned, else the files in that subdirectory.
The SerdeAPI trait connects the RESOURCE_PREFIX with the call to resources::list_resources.
The list_resources_py methods of RustCycle and RustVehicle allow exposure from Python.