Update coloredlogs requirement #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking #748 |
pjireland
reviewed
Jul 8, 2024
setup.py
Outdated
| @@ -18,7 +18,7 @@ | |||
| "attrs", | |||
| "pyyaml~=6.0", | |||
| "numexpr~=2.0", | |||
| "numpy~=1.20", | |||
| "numpy~=2.0", | |||
There was a problem hiding this comment.
Since numpy 2.0 is a very new release (June 16, 2024), it would be helpful for me (and I suspect many other users) to not yet require version 2.
There was a problem hiding this comment.
Makes sense, reverting but keeping the 2.0 improvements for a shorter hop later
misi9170
approved these changes
Jul 8, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update requirements
FLORIS uses the compatible release clause (
~=) when specificying versioning (c.f. https://peps.python.org/pep-0440/#compatible-release). This PR updates to newer versions of certain requirements that have had major releases to catch up with: numpy and colored-logs.It further adds macos to list of OS to try in CIRelated issue
Issue #938