Improve examples #956
Open
Improve examples #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve examples
Simple changes to fix ruff issues in the example files and get the plots to display when I run the example scripts.
The key functional change is adding
plt.show()andplt.close()after all plots. This makes all the plots visible when running these examples as scripts in the PyCharm IDE.I tend to use more ruff rules than currently enabled in the floris repo so some of the linting changes are above and beyond what floris requires now.
I made a few minor fixes along the way like fixing typos in axes labels.