Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combined redundant logging messages #15

Merged
merged 2 commits into from
Sep 1, 2023
Merged

combined redundant logging messages #15

merged 2 commits into from
Sep 1, 2023

Conversation

grantbuster
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (39e94b0) 98.23% compared to head (a61cb66) 98.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   98.23%   98.23%   -0.01%     
==========================================
  Files          26       26              
  Lines        2670     2669       -1     
  Branches      446      446              
==========================================
- Hits         2623     2622       -1     
  Misses         32       32              
  Partials       15       15              
Flag Coverage Δ
unittests 98.23% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
gaps/cli/execution.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Sorry about those tests... I got really in the weeds with a good portion of them lol

@grantbuster grantbuster merged commit 774a2cf into main Sep 1, 2023
10 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 1, 2023
combined redundant logging messages
@grantbuster grantbuster deleted the gb/logging branch September 1, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants