Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No job tag in out_fpath for single-node jobs #21

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Sep 8, 2023

Remove job tag in suggested out_fpath variable if job doesn't need collecting

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c040ad8) 98.10% compared to head (be02c4c) 98.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   98.10%   98.11%           
=======================================
  Files          26       26           
  Lines        2694     2705   +11     
  Branches      451      452    +1     
=======================================
+ Hits         2643     2654   +11     
  Misses         35       35           
  Partials       16       16           
Flag Coverage Δ
unittests 98.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
gaps/cli/config.py 100.00% <100.00%> (ø)
gaps/version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit 4c95bc5 into main Sep 8, 2023
10 checks passed
@ppinchuk ppinchuk deleted the pp/no_job_tag_single_node branch September 8, 2023 17:51
github-actions bot pushed a commit that referenced this pull request Sep 8, 2023
No job tag in `out_fpath` for single-node jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants