Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Command #26

Merged
merged 13 commits into from
Sep 21, 2023
Merged

Script Command #26

merged 13 commits into from
Sep 21, 2023

Conversation

ppinchuk
Copy link
Collaborator

Allow user to run one or more scripts as part of a pipeline step. A little more generic than the example in #17 - this version can handle those python commands but also non-python commands on the terminal.

@ppinchuk ppinchuk added the feature New feature or request label Sep 20, 2023
@ppinchuk ppinchuk linked an issue Sep 20, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Patch coverage: 84.37% and project coverage change: -0.17% ⚠️

Comparison is base (2a9247d) 98.21% compared to head (08f6a4b) 98.05%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   98.21%   98.05%   -0.17%     
==========================================
  Files          27       28       +1     
  Lines        2740     2771      +31     
  Branches      455      461       +6     
==========================================
+ Hits         2691     2717      +26     
- Misses         33       35       +2     
- Partials       16       19       +3     
Flag Coverage Δ
unittests 98.05% <84.37%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
gaps/cli/script.py 73.33% <73.33%> (ø)
gaps/cli/preprocessing.py 98.11% <80.00%> (-1.89%) ⬇️
gaps/cli/cli.py 100.00% <100.00%> (ø)
gaps/cli/documentation.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit 8ac7a58 into main Sep 21, 2023
10 checks passed
@ppinchuk ppinchuk deleted the pp/script_command branch September 21, 2023 00:42
github-actions bot pushed a commit that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script command
2 participants