Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch allows duplicate folder names in path #36

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

ppinchuk
Copy link
Collaborator

Fixes #35, which was an incorrect interpretation of the problem anyways.

Lists are now correctly parsed as well

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0a8cddf) 98.07% compared to head (249ec74) 98.00%.

Files Patch % Lines
gaps/batch.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   98.07%   98.00%   -0.07%     
==========================================
  Files          28       28              
  Lines        2905     2906       +1     
  Branches      486      487       +1     
==========================================
- Hits         2849     2848       -1     
- Misses         35       36       +1     
- Partials       21       22       +1     
Flag Coverage Δ
unittests 98.00% <85.71%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit 5519370 into main Dec 20, 2023
12 checks passed
@ppinchuk ppinchuk deleted the pp/batch_duplicate_path_names branch December 20, 2023 00:19
github-actions bot pushed a commit that referenced this pull request Dec 20, 2023
Batch allows duplicate folder names in path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch does not correctly copy files to directory is files to modify are in a sub-directory
2 participants