Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More batch upgrades #39

Merged
merged 2 commits into from
Dec 22, 2023
Merged

More batch upgrades #39

merged 2 commits into from
Dec 22, 2023

Conversation

ppinchuk
Copy link
Collaborator

Includes bugfix for CSV files with triple quotes (can cone from excel files),
Also includes major bugfix for forked background process to exit after pipeline completion

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (46fbe31) 98.06% compared to head (d9fee9a) 98.00%.

Files Patch % Lines
gaps/cli/pipeline.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   98.06%   98.00%   -0.07%     
==========================================
  Files          28       28              
  Lines        2901     2907       +6     
  Branches      485      486       +1     
==========================================
+ Hits         2845     2849       +4     
- Misses         35       36       +1     
- Partials       21       22       +1     
Flag Coverage Δ
unittests 98.00% <77.77%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit 646ea03 into main Dec 22, 2023
12 checks passed
@ppinchuk ppinchuk deleted the pp/more_batch_upgrades branch December 22, 2023 02:49
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants