-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Force yaw_angles
to zero in FlorisStandin
when power_setpoints
passed
#109
Conversation
These are failing tests due to a segmentation fault (the tests run fine for me locally). I'll try rerunning them again tomorrow. |
After attempting to debug this, we decided it was an upstream bug (possibly from matplotlib). Because it is not affecting our processes locally, we have decided to merge this PR and hope that the bug will be fixed upstream in future. @genevievestarke , I'm going to go ahead and merge. @paulf81 , please feel free to add any further comments from your attempt to debug the failing tests. |
@genevievestarke pointed out that an error can occur when using the
FlorisStandin
with a changing wind direction when performing active power control of the turbines. This occurs because theFlorisStandin
turbines do not perfectly track the wind direction when it changes, which causes a yaw misalignment. FLORIS is not yet capable of simultaneously simulating a yaw misalignment and a demanded power from a turbine, so the simulation errors out. See #108.The behavior is expected, and is actually tested here. However, to allow both a changing wind direction and active power control, this pull request ensures that, if a power setpoint is given to a specific turbine, it's yaw angle is set to zero to avoid raising the FLORIS error.
This is not a perfect solution, because yawing is now possibly unrealistic. If, in future, we have a Floris turbine operation model that can handle simultaneous yawing and derating, we will switch to that in the
FlorisStandin
.@genevievestarke , you should now be able to run your example of the hybrid wind/solar/battery plant.
Paul: Added some additional changes in the course of debugging tests:
ruff check
syntax