Update installation instructions #132
Conversation
…impleSolar or SolarPySAM)
… output is higher
…nto feature/standard_example merging
|
|
||
| To run locally using a standin for AMR-Wind, launch 3 separate | ||
| To run locally without the included runscript using a standin for AMR-Wind, launch 3 separate | ||
| terminals. In each, `conda activate` your hercules environment (`conda | ||
| activate hercules`). | ||
|
|
There was a problem hiding this comment.
I can't actually comment on the lines below this, because this PR doesn't change them, but they seem to assume the user has already declared a HELICS_PORT variable?
Also, hercules_runscript_dummy_amr.py doesn't exist anymore (should be some sort of florisstandin runscript)
There was a problem hiding this comment.
Yeah, I'm not positive about this whole section. In the same way as the runscript in each folder might be a little different, the manual version might also be a little different and the best approach would be just to enter the lines appearing in the runscript as they appear. Possibly in 3 terminals, or using the & to unblock, maybe just shorten this section to something more like "to be sure, it's possible to enter the commands in the runscript directly..."?
There was a problem hiding this comment.
I think it makes sense to encourage people to use the run_script.sh . So, perhaps those instructions should come first. But then, maybe it is worth taking the example of one of the run_script.sh , and talking through what each line is doing (and explain that it is possible to run this from three separate terminals, if that's what the user would prefer to do)?
This small PR updates the installation codes and instructions to make a few improvements to current practice. Main current changes are:
Changes