Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update reqs and add simple test #36

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Nov 29, 2023

This pull requests adds/improves some software components ahead of the v1 changes.

It addresses: Issue #34 and Issue #31 , changes include:

  1. Removing unused requirements
  2. Adding semantic versioning using compatible release specifier
  3. Adds a first pytest, which just declares an empty py-sim but can test everything imports
  4. Adds a continuous integration workflow for automatic testing
  5. Removes un-used requirements.txt
  6. Adds vs-code items to gitignore

Pulling to main to cause the ci to go into effect and can back merge to develop after

Pull request closes #34 and closes #31

@paulf81 paulf81 added the enhancement New feature or request label Nov 29, 2023
@paulf81 paulf81 added this to the v0.2 milestone Nov 29, 2023
@paulf81 paulf81 self-assigned this Nov 29, 2023
Copy link
Collaborator

@misi9170 misi9170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good---might have to get this onto main and then fix any possible bugs if they come up, because I'm not sure how to test any of this really. But good to start on the CI path for Hercules

@paulf81
Copy link
Collaborator Author

paulf81 commented Nov 30, 2023

I ran the tests locally (and I think this pull request ran the tests too), but yeah, might also be different after merging...

Copy link
Collaborator

@genevievestarke genevievestarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@paulf81
Copy link
Collaborator Author

paulf81 commented Nov 30, 2023

Merging!

@paulf81 paulf81 merged commit 5c6ab47 into NREL:main Nov 30, 2023
@paulf81 paulf81 deleted the feature/update_reqs_and_add_simple_test branch November 30, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants