-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update reqs and add simple test #36
Feature/update reqs and add simple test #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good---might have to get this onto main and then fix any possible bugs if they come up, because I'm not sure how to test any of this really. But good to start on the CI path for Hercules
I ran the tests locally (and I think this pull request ran the tests too), but yeah, might also be different after merging... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Merging! |
This pull requests adds/improves some software components ahead of the v1 changes.
It addresses: Issue #34 and Issue #31 , changes include:
Pulling to main to cause the ci to go into effect and can back merge to develop after
Pull request closes #34 and closes #31