[BUG] Hotfix: track floris v4 change in input file "turbulence_intensities" #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misi9170
changed the title
ZackTully
pushed a commit
to ZackTully/hercules
that referenced
this pull request
Feb 5, 2024
misi9170
added a commit
that referenced
this pull request
Feb 6, 2024
* simple battery unit tests * update WHOC WindBatteryController name * Add alternative standin for AMR-wind that runs FLORIS (#63) * Setting up example to work through. * bugfix: fix old dummy name. * Constructs fi object. * appears to run as expected. * Various updates for smoother running. * Ruff. * Remove gch yaml in favor of a default dictionary defined in floris_standin.py * Undo ruff format, which fights with ruff. * Tests for FlorisStandin. * ruff * Adding correct floris branch to github workflow for testing. * try again... * and again. * ready to test external data. * Test for external data built out and passing. * ruff. * Remove obselete handling. * match reconfiguration of turbine package. * add pip install instructions. * ruff :( * Standin power specified in kW; emulator uses correct actuator. * Update test to reflect kW units. * remove unused JoukowskyDisk information. * Adding a comment explaining units in Floris power calculation * Adjusting to meet Ruff standards * Line shortened. --------- Co-authored-by: Genevieve Starke <Genevieve.Starke@nrel.gov> * Update README.md (#65) Co-authored-by: jfrederik-nrel <120053750+jfrederik-nrel@users.noreply.github.com> * Bugfix -- track floris v4 change in input file. (#66) --------- Co-authored-by: Zachary <ztully@nrel.gov> Co-authored-by: misi9170 <39596329+misi9170@users.noreply.github.com> Co-authored-by: Genevieve Starke <Genevieve.Starke@nrel.gov> Co-authored-by: genevievestarke <103534902+genevievestarke@users.noreply.github.com> Co-authored-by: jfrederik-nrel <120053750+jfrederik-nrel@users.noreply.github.com> Co-authored-by: misi9170 <michael.sinner@nrel.gov>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to the FLORIS v4 branch mean that the stand-in broke. This fixes that issue. This will likely won't be the last time this happens before FLORIS v4 is released.