-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable passing power setpoints to wind simulators #76
Merged
genevievestarke
merged 21 commits into
NREL:develop
from
misi9170:feature/floris-derating
Feb 26, 2024
Merged
Enable passing power setpoints to wind simulators #76
genevievestarke
merged 21 commits into
NREL:develop
from
misi9170:feature/floris-derating
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now allows users to specify external data in a separate csv file, as well as specifying the name of the output file in the |
…f simulation does not start at expected start_time
genevievestarke
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floris v4 allows wind turbines to be derated by passing them power setpoints. This pull request takes advantage of that functionality and implements it in the
FlorisStandin
. However, AMRWind does not currently handle derating turbines, so this code will not change the power output from AMRWind. Additionally, we will need to check that whenpower_setpoints
are passed to AMRWind, they are simply ignored, rather than throwing an error.I am currently working on a pull request for WHOC that will take advantage of this derating capability in Hercules (with the
FlorisStandin
). Once that PR is in place and I'm happy that both features work, I'll change the DRAFT status of this PR.