Feature/floris electrolyzer example #77
Conversation
|
Addresses #70 |
Merging develop in with electrolyzer example branch
…ing folder to represent new example
|
|
||
| helics_broker -t zmq -f 2 --loglevel="debug" --local_port=$HELICS_PORT & | ||
| python3 hercules_runscript_CLcontrol.py hercules_input_000.yaml >> loghercules_cl 2>&1 & | ||
| python3 floris_runscript.py amr_input.inp amr_standin_data-higher.csv >> logfloris_cl 2>&1 |
There was a problem hiding this comment.
I think that the amr_standin_data-higher.csv argument is not needed here? Or perhaps it is, but it doesn't appear in the repository, so I wasn't able to run the example with this line as is. However, it does run when I take out the amr_standin_data-higher.csv argument though (but I'm not sure if it's running the right thing... :) )
There was a problem hiding this comment.
Yep, I changed the name for this and didn't update it. It should be floris_standin_data.csv and is updated now!
There was a problem hiding this comment.
Thanks! While you're at it, do the output files need the _cl appended? This causes them to be missed by the .gitignore, so it might be best to name them loghercules and logfloris---or, update the .gitignore to ignore loghercules* and logfloris*, which might be a better general solution?
There was a problem hiding this comment.
The suggested updates to .gitignore are now in #93
This pull request replaces the AMR wind standin in Example 05 with the Floris standin. This will be updated when Floris is able to take in power set points.