Skip to content
This repository was archived by the owner on Mar 6, 2024. It is now read-only.

Wall translation fixes and water heater EF rounding #164

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Conversation

bpark1327
Copy link
Collaborator

@bpark1327 bpark1327 commented Sep 13, 2021

Pull Request Description

  • Remove the code that rounds up the EF and UEF of water heaters
  • Relax has_rigid_ins condition
  • For each side of walls, if there is only one wall, use the assembly code directly as wall assembly code

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Code changes (must work)
  • Test exercising your feature or bug fix. Check the coverage report in the build artifacts.
  • All other unit tests passing
  • Update translation docs

@bpark1327 bpark1327 self-assigned this Sep 13, 2021
@github-actions
Copy link

github-actions bot commented Sep 13, 2021

File Coverage
All files 93%
__init__.py 83%
base.py 93%
exceptions.py 96%
hpxml2.py 98%
hpxml3.py 94%

Minimum allowed coverage is 83%

Generated by 🐒 cobertura-action against 5befb96

@bpark1327 bpark1327 requested a review from nmerket September 13, 2021 22:40
@bpark1327 bpark1327 marked this pull request as ready for review September 13, 2021 22:40
@nmerket nmerket changed the title Update base.py Remove requirement for InsulationMaterial/Rigid for wall constructions to translate to ps construction code Sep 13, 2021
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nmerket nmerket changed the title Remove requirement for InsulationMaterial/Rigid for wall constructions to translate to ps construction code Wall translation fixes and water heater EF rounding Sep 13, 2021
@nmerket nmerket merged commit 338ec5c into master Sep 13, 2021
@nmerket nmerket deleted the update_base_py branch September 13, 2021 22:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants