Skip to content
This repository was archived by the owner on Mar 6, 2024. It is now read-only.

Update duct blaster measurement #183

Merged
merged 6 commits into from
Jan 3, 2022
Merged

Conversation

bpark1327
Copy link
Collaborator

@bpark1327 bpark1327 commented Dec 30, 2021

Pull Request Description

Update quantitative duct leakage modeling method to handle a case where duct leakage measurement for supply and return ducts are entered separately

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Code changes (must work)
  • Test exercising your feature or bug fix. Check the coverage report in the build artifacts.
  • All other unit tests passing
  • Update translation docs

@bpark1327 bpark1327 self-assigned this Dec 30, 2021
@github-actions
Copy link

github-actions bot commented Dec 30, 2021

File Coverage
All files 93%
__init__.py 83%
base.py 93%
exceptions.py 96%
hpxml2.py 98%
hpxml3.py 94%

Minimum allowed coverage is 83%

Generated by 🐒 cobertura-action against e1895ac

@bpark1327 bpark1327 mentioned this pull request Dec 30, 2021
4 tasks
@bpark1327 bpark1327 requested a review from shorowit December 30, 2021 05:39
@bpark1327 bpark1327 marked this pull request as ready for review December 30, 2021 05:39
Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I made some minor documentation suggestions.

bpark1327 and others added 3 commits January 3, 2022 14:11
Co-authored-by: Scott Horowitz <scott.horowitz@nrel.gov>
Co-authored-by: Scott Horowitz <scott.horowitz@nrel.gov>
Co-authored-by: Scott Horowitz <scott.horowitz@nrel.gov>
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work.

@bpark1327 bpark1327 merged commit e26fcc5 into master Jan 3, 2022
@bpark1327 bpark1327 deleted the update_duct_blaster_measurement branch January 3, 2022 22:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants