Skip to content
This repository was archived by the owner on Mar 6, 2024. It is now read-only.

Knee walls #184

Merged
merged 45 commits into from
Feb 24, 2022
Merged

Knee walls #184

merged 45 commits into from
Feb 24, 2022

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Jan 5, 2022 •
edited
Loading

Pull Request Description

Adds knee walls support.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Code changes (must work)
  • Test exercising your feature or bug fix. Check the coverage report in the build artifacts.
  • All other unit tests passing
  • Update translation docs

shorowit and others added 12 commits December 10, 2021 16:28
@shorowit
Merge commit '091de221919f6c564f78a6351c04e4699a1e4166' into low_e_st…
1d36037 
…orms
@shorowit
Merge commit 'ef2866ac835b9b8ac06c0f6c33c90df3abd69edd' into low_e_st…
8e510b4 
…orms
@nmerket
adding knee walls and reorganizing json schema for attics/roofs
24c18af
@nmerket
Revert "adding knee walls and reorganizing json schema for attics/roofs"
4a70219 
This reverts commit 3190798.
@nmerket
Merge remote-tracking branch 'origin/master' into knee_walls
fa0369d
@nmerket
Merge commit '1a1fbdb9d8acdd9f69559e6adec02f75642ec3ba' into knee_walls
d20245c
@bpark1327
Merge branch 'master' of github.com:NREL/OpenStudio-HEScore into low_…
2869335 
…e_storms
@nmerket
adding new zone_roof elements
98106eb
@nmerket
adding validation rules for knee walls and roofs
93795e4
@nmerket
updates hescore-hpxml example files
ec91c17
@nmerket
setting maximum knee wall area to 5000
aa2a5b5
@nmerket
Merge commit '9a66b11a4a908d896943cf4507387c421142d38a' into knee_walls
67a9fda
@nmerket nmerket self-assigned this Jan 5, 2022
yzhou601 and others added 8 commits January 7, 2022 18:11
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HEScore i…
47eb4b1 
…nto high-efficiency-heat-pump
@yzhou601
Merge commit 'bc8fbd8578574250a0850cc9307aac8e19045f9d' into high-eff…
3deaea5 
…iciency-heat-pump
@yzhou601
Merge commit 'ebd561d4a655f7f36d7e4655922d72f7b907caad' into high-eff…
daec79e 
…iciency-heat-pump
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HEScore i…
81fe6fd 
…nto knee_walls
@shorowit
Merge commit 'fb92996655bb9dd827585101c72076b580e13222' into latest-h…
8a1456c 
…escore-hpxml
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HEScore i…
1723a19 
…nto high-efficiency-heat-pump
@nmerket
Merge remote-tracking branch 'origin/master' into knee_walls
f7780d9
@nmerket
separating ceiling_area and roof_area
290af16
@nmerket
Copy link
Member Author

nmerket commented Jan 27, 2022

Question: House 5 has a vented attic and roof insulation. Should we allow that? I'm parsing out the attic ceiling area.

@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

File Coverage
All files 93% ✅
__init__.py 83% ✅
base.py 94% ✅
exceptions.py 96% ✅
hpxml2.py 91% ✅
hpxml3.py 87% ✅

Minimum allowed coverage is 83%

Generated by 🐒 cobertura-action against 1f1d9bc

@nmerket nmerket requested a review from bpark1327 February 1, 2022 18:05
@nmerket nmerket marked this pull request as ready for review February 1, 2022 18:05
bpark1327
bpark1327 reviewed Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@bpark1327 bpark1327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I have a couple of minor comments/questions.

@bpark1327 bpark1327 self-requested a review February 17, 2022 18:03
@nmerket nmerket merged commit ac5953a into master Feb 24, 2022
@nmerket nmerket deleted the knee_walls branch February 24, 2022 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shorowit shorowit shorowit left review comments

@bpark1327 bpark1327 bpark1327 approved these changes

Assignees

@nmerket nmerket

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nmerket @shorowit @bpark1327 @yzhou601