Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fabs to std::abs per SAM #1223 #37

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Update fabs to std::abs per SAM #1223 #37

merged 2 commits into from
Nov 10, 2022

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Nov 8, 2022

Other repos will have similar pull request coming!

@sjanzou sjanzou self-assigned this Nov 8, 2022
@sjanzou sjanzou requested review from brtietz and tyneises November 8, 2022 10:05
@sjanzou
Copy link
Collaborator Author

sjanzou commented Nov 8, 2022

Address SAM issue 1223 in the lk repo NREL/SAM#1223

@sjanzou sjanzou mentioned this pull request Nov 8, 2022
Closed
tyneises
tyneises approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@tyneises tyneises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. My main concern was instances of abs() without the std:: prefix. Do you also recommend changing all the fabs() in the code base to std::abs, as you do here?

brtietz
brtietz reviewed Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, but please avoid commented out code when possible

src/stdlib.cpp Outdated
@@ -35,8 +35,7 @@
#include <future>
#include <chrono>

#include <cmath>
#include <float.h>
//#include <float.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented out code

@sjanzou sjanzou merged commit 48d2c53 into develop Nov 10, 2022
@sjanzou sjanzou deleted the SAM_1223 branch November 10, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brtietz brtietz brtietz left review comments

@tyneises tyneises tyneises approved these changes

Assignees

@sjanzou sjanzou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjanzou @brtietz @tyneises