Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add methods to convert results to geodataframe #193

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

nreinicke
Copy link
Collaborator

Adds new convenience methods matches_to_geodataframe and path_to_geodataframe

@nreinicke nreinicke requested a review from jhoshiko as a code owner November 8, 2024 00:26
@nreinicke
Copy link
Collaborator Author

@jhoshiko - Do you mind taking a look at this? I accidentally merged the new geodataframe methods into main and so they won't show up in the diff 🤦

@nreinicke
Copy link
Collaborator Author

But, you can find them here:

def matches_to_geodataframe(self) -> gpd.GeoDataFrame:

def path_to_geodataframe(self) -> gpd.GeoDataFrame:

Copy link
Collaborator

@jhoshiko jhoshiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha it's definitely Friday. This all look good to me!

@nreinicke nreinicke merged commit 6f2aab1 into main Nov 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants