Bnb32/issue46 #47
Merged
Bnb32/issue46 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oop. Pass this check to eagle to skip running and just update status file.
grantbuster
approved these changes
Mar 11, 2022
Yeah a bunch. The one thing that annoys me is the dummy runs are interpreted as failed so we get a message about that on new submissions. Changing that would require digging in reV though I guess. Otherwise it works well. |
|
Thats fine though, its good if those jobs "fail" because then the pipeline wont move past the current step and those jobs will be submitted once you disable the debug feature |
Yeah I'd just rather it not move past but not say theyre failed. Just nitpicking though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to specify "debug_day" in config_nsrdb.json. If this is null things will run normally. If not null only debug_day will be run and all other jobs in doy_range will only be included in the status file.