Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edge case fix for collection - get_slices #57

Merged
merged 1 commit into from
Mar 20, 2023
Merged

edge case fix for collection - get_slices #57

merged 1 commit into from
Mar 20, 2023

Conversation

bnb32
Copy link
Collaborator

@bnb32 bnb32 commented Mar 10, 2023

No description provided.

@bnb32 bnb32 added the bug Something isn't working label Mar 10, 2023
@bnb32 bnb32 linked an issue Mar 10, 2023 that may be closed by this pull request
incorrect logic in collection? #56
Closed
@bnb32 bnb32 requested a review from grantbuster March 10, 2023 15:15
grantbuster
grantbuster approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Good example of where trying to be too fancy with python booleans can get you into trouble.

@bnb32 bnb32 merged commit 745d1c1 into main Mar 20, 2023
@bnb32 bnb32 deleted the bnb/collection_edge_case_fix branch March 20, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantbuster grantbuster grantbuster approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect logic in collection?
2 participants
@bnb32 @grantbuster