-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FARMS-DNI #58
Use FARMS-DNI #58
Conversation
@grantbuster are the files used in the all sky tests precomputed data? The naming suggests theyre surfrad data but Yu says they also include nsrdb outputs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, main thing is we need a farms_dni kwarg. Also need to update requirements and version. Tests might pass once we do a FARMS version release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to fix the tests and then lets merge
Yeah, Yu is still working on that. |
No description provided.