Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FARMS-DNI #58

Merged
merged 55 commits into from
Apr 28, 2023
Merged

Use FARMS-DNI #58

merged 55 commits into from
Apr 28, 2023

Conversation

xieyupku
Copy link
Collaborator

No description provided.

nsrdb/all_sky/all_sky.py Outdated Show resolved Hide resolved
nsrdb/all_sky/all_sky.py Outdated Show resolved Hide resolved
nsrdb/all_sky/all_sky.py Outdated Show resolved Hide resolved
@bnb32
Copy link
Collaborator

bnb32 commented Mar 30, 2023

@grantbuster are the files used in the all sky tests precomputed data? The naming suggests theyre surfrad data but Yu says they also include nsrdb outputs.

Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, main thing is we need a farms_dni kwarg. Also need to update requirements and version. Tests might pass once we do a FARMS version release.

nsrdb/all_sky/all_sky.py Outdated Show resolved Hide resolved
nsrdb/data_model/clouds.py Outdated Show resolved Hide resolved
nsrdb/data_model/data_model.py Outdated Show resolved Hide resolved
@grantbuster
Copy link
Member

hey @bnb32, can you add the disc_on kwarg to two more places to make it fully integrated into the CLI? Sorry, i know the cli is a tangled web.

col_chunk=cmd_args.get('col_chunk', 10))

col_chunk=cmd_args.get('col_chunk', 500))

Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to fix the tests and then lets merge

@bnb32
Copy link
Collaborator

bnb32 commented Apr 18, 2023

Looks good, just need to fix the tests and then lets merge

Yeah, Yu is still working on that.

nsrdb/all_sky/all_sky.py Outdated Show resolved Hide resolved
@bnb32 bnb32 merged commit 7337826 into main Apr 28, 2023
@bnb32 bnb32 deleted the FARMS-DNI branch April 28, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants