Bnb32/issue51 #59
Merged
Bnb32/issue51 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnb32
force-pushed
the
bnb32/issue51
branch
4 times, most recently
from
9d7f425
to
ec281b3
Compare
Fixes #51. added properties to base handler and merra handler for accessing next date file. edited temporal intepolation to integrate next date data. pandas date_range wrapper addition.
bnb32
force-pushed
the
bnb32/issue51
branch
2 times, most recently
from
ae304a1
to
200bbd2
Compare
grantbuster
approved these changes
Apr 13, 2023
nsrdb/data_model/base_handler.py
Outdated
| Parameters | ||
| ---------- | ||
| key : str | ||
| The should be either 'pattern' or 'next pattern', corresponding to |
There was a problem hiding this comment.
need underscore on "next pattern"
| if self.next_file_exists: | ||
| data = np.concatenate([data, self._get_data(self.next_file)], | ||
| axis=0) | ||
| return data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves MERRA interpolation issue #51. Also incorporates various changes to accommodate pandas v2.0.0.
With interpolation fix:
Without: