Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

night cycling change - for 0.4.x #111

Merged
merged 3 commits into from
Mar 3, 2021
Merged

night cycling change - for 0.4.x #111

merged 3 commits into from
Mar 3, 2021

Conversation

kflemin
Copy link
Collaborator

@kflemin kflemin commented Mar 2, 2021

Night cycling change - fixing it in 0.4.x version

@kflemin kflemin requested a review from DavidGoldwasser March 2, 2021 23:34
@DavidGoldwasser
defining manager_night_cycles
6266bd8
@DavidGoldwasser
removing probelmatic code
6e52d52 
I don't know that the check was doing anything that was necessary.
DavidGoldwasser
DavidGoldwasser approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@DavidGoldwasser DavidGoldwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few changes to get test to pass.

@DavidGoldwasser DavidGoldwasser merged commit 8c835dc into develop Mar 3, 2021
@DavidGoldwasser DavidGoldwasser deleted the night-cycling-change-0.4.X branch March 3, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGoldwasser DavidGoldwasser DavidGoldwasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kflemin @DavidGoldwasser