Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup readme and rework BCL tasks #133

Merged
merged 2 commits into from
Oct 4, 2021
Merged

cleanup readme and rework BCL tasks #133

merged 2 commits into from
Oct 4, 2021

Conversation

kflemin
Copy link
Collaborator

@kflemin kflemin commented Sep 17, 2021 •
edited
Loading

  • remove old BCL stuff
  • rework README to add compatibility matrix and openstudio contribution policy link

This will work once BCL2 is transferred to BCL url

TODO: update gemspec with new version of bcl-gem when that's released

@kflemin kflemin requested a review from nllong September 17, 2021 17:07
nllong
nllong approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks for cleaning up the BCL code!

@nllong
Copy link
Member

nllong commented Sep 27, 2021

@kflemin -- any reason not to merge this? Waiting until BCL 2.0 release?

@kflemin
Copy link
Collaborator Author

kflemin commented Sep 27, 2021

@nllong exactly

@kflemin
Copy link
Collaborator Author

kflemin commented Oct 4, 2021

@nllong, bcl 2.0 is live at the bcl.nrel.gov URL. I'm going to go ahead and merge this.

@nllong
Copy link
Member

nllong commented Oct 4, 2021

sweet!

@nllong nllong merged commit 4c61f87 into develop Oct 4, 2021
@nllong nllong deleted the cleanup branch October 4, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nllong nllong nllong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kflemin @nllong