Intersect tests 072021 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It first glance may be surface matching tolerance issue and not intersection. I'll see if I can access tolerance setting from API
Still need to address three errors. I have idea on work around for two of them.
This fully bypasses both intersection and matching which bypasses NREL/OpenStudio#4372 for now but it still needs to be fixed. I' need to clean this up a bit later tonight, and then address last failing test.
Set one test to skip. It is same as passing test but relies on OpenStudio intersection and matching. Maybe can try to get that working on future release.
At some point a sort by floor_area got reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to do more testing with this and latest OS installer, also need to pull develop of ext gem into this.