Merge pull request #1435 from NREL/fix/issue1423

fix typo and delete extra methods
NREL · Mar 13, 2023 · c5fbf4e · c5fbf4e
2 parents 50d4bcb + b2a7ed1
commit c5fbf4e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/lib/openstudio-standards/btap/btap.model.rb b/lib/openstudio-standards/btap/btap.model.rb
@@ -8,7 +8,7 @@ class OpenStudio::Model::Construction
   #insulation layer.
   #@author Phylroy A. Lopez <plopez@nrcan.gc.ca>
   #@return OpenStudio::Model::Material insulation_material_layer
-  def self.find_and_set_insulaton_layer()
+  def self.find_and_set_insulation_layer()
       insulation_material_layer = nil
       #return if there is already a defined insulation layer.
       return self.insulation unless self.insulation.empty?
@@ -77,7 +77,7 @@ def customize(model,
 
     if  conductance.kind_of?(Float)
       #re-find insulation layer
-      find_and_set_insulaton_layer(self.model,new_construction)
+      find_and_set_insulation_layer(self.model,new_construction)
 
       #Determine how low the resistance can be set. Subtract existing insulation
       #Values from the total resistance to see how low we can go.

diff --git a/lib/openstudio-standards/btap/envelope.rb b/lib/openstudio-standards/btap/envelope.rb
@@ -504,13 +504,13 @@ def test_create_opaque_construction()
 
             #This method will test find and set insulation layer.
             # @author Phylroy A. Lopez <plopez@nrcan.gc.ca>
-            def test_find_and_set_insulaton_layer()
+            def test_find_and_set_insulation_layer()
               construction = BTAP::Resources::Envelope::Constructions::create_construction(@model, "test construction", [@opaque, @air_gap, @insulation, @massless, @opaque])
 
               #check insulation was not set.
               assert((construction.insulation().empty?))
               #now set it.
-              BTAP::Resources::Envelope::Constructions::find_and_set_insulaton_layer(@model, [construction])
+              BTAP::Resources::Envelope::Constructions::find_and_set_insulation_layer(@model, [construction])
               #Now check that it found the insulation  value.
               assert(construction.insulation().get == @insulation)
             end
@@ -544,7 +544,7 @@ def test_create_new_construction_based_on_exisiting()
         #@param model [OpenStudio::Model::Model]
         #@param constructions_array [BTAP::Common::validate_array]
         #@return <String> insulating_layers
-        def self.find_and_set_insulaton_layer(model, constructions_array)
+        def self.find_and_set_insulation_layer(model, constructions_array)
           constructions_array = BTAP::Common::validate_array(model, constructions_array, "Construction")
           insulating_layers = Array.new()
           constructions_array.each do |construction|
@@ -619,7 +619,7 @@ def self.customize_opaque_construction(model, construction, conductance)
 
           if conductance.kind_of?(Float)
             #re-find insulation layer
-            find_and_set_insulaton_layer(model, new_construction)
+            find_and_set_insulation_layer(model, new_construction)
 
             #Determine how low the resistance can be set. Subtract exisiting insulation
             #Values from the total resistance to see how low we can go.

diff --git a/lib/openstudio-standards/standards/Standards.Construction.rb b/lib/openstudio-standards/standards/Standards.Construction.rb
@@ -31,7 +31,7 @@ def construction_set_u_value(construction, target_u_value_ip, insulation_layer_n
     if insulation_layer_name.nil? && target_u_value_ip == 0.0
       # Do nothing if the construction already doesn't have an insulation layer
     elsif insulation_layer_name.nil?
-      insulation_layer_name = find_and_set_insulaton_layer(construction).name
+      insulation_layer_name = find_and_set_insulation_layer(construction).name
     end
 
     # Remove the insulation layer if the specified U-value is zero.