Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control_type not defined in PlantLoop plant_loop_apply_prm_baseline_chilled_water_pumping_type for HeaderedPumpsVariableSpeed #1748

Closed
jmarrec opened this issue May 28, 2024 · 0 comments · Fixed by #1749

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented May 28, 2024

pri_control_type and sec_control_type are defined, control_type isn't.

This crashes when you do have HeaderedPumpsVariableSpeed (and does the correct thing for PumpVariableSpeed).

plant_loop.supplyComponents.each do |sc|
if sc.to_PumpVariableSpeed.is_initialized
pump = sc.to_PumpVariableSpeed.get
pump_variable_speed_set_control_type(pump, pri_control_type)
elsif sc.to_HeaderedPumpsVariableSpeed.is_initialized
pump = sc.to_HeaderedPumpsVariableSpeed.get
headered_pump_variable_speed_set_control_type(pump, control_type)
end
end
# Modify all the secondary pumps besides constant pumps
plant_loop.demandComponents.each do |sc|
if sc.to_PumpVariableSpeed.is_initialized
pump = sc.to_PumpVariableSpeed.get
pump_variable_speed_set_control_type(pump, sec_control_type)
elsif sc.to_HeaderedPumpsVariableSpeed.is_initialized
pump = sc.to_HeaderedPumpsVariableSpeed.get
headered_pump_variable_speed_set_control_type(pump, control_type)
end
end

Caught in 179D, is present since at least 0.4.0.

jmarrec added a commit that referenced this issue May 28, 2024
…m_baseline_chilled_water_pumping_type for HeaderedPumpsVariableSpeed
mdahlhausen added a commit that referenced this issue Jun 3, 2024
…t_defined

Fix #1748 - control_type not defined in PlantLoop plant_loop_apply_prm_baseline_chilled_water_pumping_type for HeaderedPumpsVariableSpeed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant