Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baseline boiler naming can be improved. #230

Closed
eringold opened this issue Apr 25, 2017 · 0 comments · Fixed by #1436
Closed

Baseline boiler naming can be improved. #230

eringold opened this issue Apr 25, 2017 · 0 comments · Fixed by #1436
Assignees
@asparke2
Labels
severity - Minor Bug Standard - 90.1
Milestone
0.3.1

Comments

@eringold
Copy link
Collaborator

eringold commented Apr 25, 2017 •
edited
Loading

Boilers are named first here based on number, then here based on size and efficiency.

  • The code in Part 1 yields repeated numbering:
    HOT WATER LOOP BOILER 1 OF 2
    HOT WATER LOOP BOILER 1 OF 2 2 OF 2
    The logic could probably be simplified, since there will only ever be one or two boilers.

  • The code in Part 2 appends the combined boiler capacity to each boiler:
    HOT WATER LOOP BOILER 1 OF 2 2063KBTU/HR 0.8 THERMAL EFF
    HOT WATER LOOP BOILER 1 OF 2 2 OF 2 2063KBTU/HR 0.8 THERMAL EFF
    Here capacity_kbtu_per_hr should be multiplied by boiler sizing_factor.
@asparke2 asparke2 self-assigned this Jul 29, 2017
@mdahlhausen mdahlhausen added this to the 0.3.1 milestone Mar 8, 2023
mdahlhausen added a commit that referenced this issue Mar 12, 2023
@mdahlhausen
change prm boiler naming
0343bf6 
- Fix #230
- Update to PRM method to have better naming for boilers
- Re-apply efficiency standard because multiple boilers with lower capacity may have different efficiency standards at the smaller size
@mdahlhausen mdahlhausen mentioned this issue Mar 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asparke2 asparke2

Labels
severity - Minor Bug Standard - 90.1
Projects
None yet
Milestone
0.3.1
Development

Successfully merging a pull request may close this issue.

change prm boiler naming NREL/openstudio-standards
3 participants
@asparke2 @mdahlhausen @eringold