Pulling changes in nrcan_340 into nrcan_os320 #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th stray equipment when running BTAP.
…nts from geometry models.
…utdoor air. Used to be defaulted to ZoneSum but must be set explicitly in OS 3.2.0.
…utdoor air in additional system definitions. Used to be defaulted to ZoneSum but must be set explicitly in OS 3.2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nrcan_340 changes will be incorporated into nrcan branch later.
These changes include:
-Setting the mechanical ventilation controller outdoor air method to 'ZoneSum' explicitly rather than defaulting it to that (which changes in OS 3.2.0) when defining NECB systems in the NECB2011 class and BTAPPRE1980 class
-Removing additional components from the geometry files
-Additional error handling in qaqc output