Adding assert to handle model generating unsuccessfully case in the r… #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove_transfer function
mdahlhausen
requested changes
Jan 23, 2023
There was a problem hiding this comment.
There is an issue with model generation (path names I believe?) and we should solve that issue rather setting up an integration test assert that model generation fails.
We can add an error statement here so that the model generation fails gracefully. Use an error statement, not an 'assert'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emove_transfer function
Addressing the #1395 item number 3.
Adding assert to handle exception when the model generation is failed.