Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete OpenStudio Model Object autosizing and hardsizing methods #1410

Merged
merged 8 commits into from
Feb 13, 2023
Merged

Remove obsolete OpenStudio Model Object autosizing and hardsizing methods #1410

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2dd908d
Removes autosizing and hardsizing methods that have been in OS C++ AP…
asparke2 Jan 12, 2023
134c888
Switch to component-specific getAutosizedValue methods defined in OS …
asparke2 Jan 20, 2023
ffbe19f
Switch to direct component-level autosizedFoo methods
asparke2 Feb 3, 2023
a2f4016
autosizedDesignSupplyAirFlowRate optional lookup
mdahlhausen Feb 8, 2023
0e15728
Add a tolerance check to necb regression tests
mdahlhausen Feb 8, 2023
8355cb0
correct pump autosizedRatedPowerConsumption lookup
mdahlhausen Feb 9, 2023
92c013c
increase error percentage to above rounding tolerance
mdahlhausen Feb 13, 2023
9d14363
Merge branch 'master' into remove_autosizing_methods
mdahlhausen Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 0 additions & 81 deletions lib/openstudio-standards/hvac_sizing/Siz.AirConditionerVariableRefrigerantFlow.rb
View file
Open in desktop

This file was deleted.

91 changes: 8 additions & 83 deletions lib/openstudio-standards/hvac_sizing/Siz.AirLoopHVAC.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,41 +2,17 @@
# Reopen the OpenStudio class to add methods to apply standards to this object
class OpenStudio::Model::AirLoopHVAC

# Sets all auto-sizeable fields to autosize
def autosize
self.autosizeDesignSupplyAirFlowRate
end

# Takes the values calculated by the EnergyPlus sizing routines
# and puts them into this object model in place of the autosized fields.
# Must have previously completed a run with sql output for this to work.
def applySizingValues

design_supply_air_flow_rate = self.autosizedDesignSupplyAirFlowRate
if design_supply_air_flow_rate.is_initialized
self.setDesignSupplyAirFlowRate(design_supply_air_flow_rate.get)
end

end

# returns the autosized design supply air flow rate as an optional double
def autosizedDesignSupplyAirFlowRate

return self.model.getAutosizedValue(self, 'Design Supply Air Flow Rate', 'm3/s')

end

# Retrieves an airloop sum of air terminal minimum heating flow rates: sum(Vpz_min)
def autosizeSumMinimumHeatingAirFlowRates
result = OpenStudio::OptionalDouble.new
name = self.name.get.upcase
sql = self.model.sqlFile
if sql.is_initialized
sql = sql.get
query = "SELECT Value
sql = sql.get
query = "SELECT Value
FROM tabulardatawithstrings
WHERE ReportName='ComponentSizingSummary'
AND ReportForString='Entire Facility'
WHERE ReportName='ComponentSizingSummary'
AND ReportForString='Entire Facility'
AND TableName='AirLoopHVAC'
AND ColumnName='Sum of Air Terminal Minimum Heating Flow Rates'
AND RowName='#{name}'
Expand All @@ -53,68 +29,17 @@ def autosizeSumMinimumHeatingAirFlowRates

end

# Retrieve an airloop's design outdoor air intake (Vot)
# Ideally, this would only be used to retrieve Vot when
# calculated by EnergyPlus' built-in design VRP calculations
def autosize621OutdoorAirIntakeFlow
flow_types = ['Heating', 'Cooling']
flow_rates = []
flow_types.each do |flow_type|
result = OpenStudio::OptionalDouble.new
name = self.name.get.upcase
sql = self.model.sqlFile
if sql.is_initialized
sql = sql.get
query = "SELECT Value
FROM tabulardatawithstrings
WHERE ReportName='Standard62.1Summary'
AND ReportForString='Entire Facility'
AND TableName='System Ventilation Requirements for #{flow_type}'
AND ColumnName='Outdoor Air Intake Flow Vot'
AND RowName='#{name}'
AND Units='m3/s'"
val = sql.execAndReturnFirstDouble(query)
if val.is_initialized
result = OpenStudio::OptionalDouble.new(val.get)
end
# Inconsistency in column name in EnergyPlus 9.0:
# "Outdoor Air Intake Flow - Vot" vs "Outdoor Air Intake Flow Vot"
# The following could be deleted if the inconsistency was ever fixed
if result.to_f == 0.0
query = "SELECT Value
FROM tabulardatawithstrings
WHERE ReportName='Standard62.1Summary'
AND ReportForString='Entire Facility'
AND TableName='System Ventilation Requirements for #{flow_type}'
AND ColumnName='Outdoor Air Intake Flow - Vot'
AND RowName='#{name}'
AND Units='m3/s'"
val = sql.execAndReturnFirstDouble(query)
if val.is_initialized
result = OpenStudio::OptionalDouble.new(val.get)
end
end
else
OpenStudio::logFree(OpenStudio::Error, 'openstudio.model.Model', 'Model has no sql file containing results, cannot lookup data.')
end
flow_rates << result.to_f
end

return flow_rates.max

end

# Retrieve an airloop's sum of air terminal maximum flow rates: sum(Vpz)
def autosizeSumAirTerminalMaxAirFlowRate
result = OpenStudio::OptionalDouble.new
name = self.name.get.upcase
sql = self.model.sqlFile
if sql.is_initialized
sql = sql.get
query = "SELECT Value
sql = sql.get
query = "SELECT Value
FROM tabulardatawithstrings
WHERE ReportName='ComponentSizingSummary'
AND ReportForString='Entire Facility'
WHERE ReportName='ComponentSizingSummary'
AND ReportForString='Entire Facility'
AND TableName='AirLoopHVAC'
AND ColumnName='Sum of Air Terminal Maximum Flow Rates'
AND RowName='#{name}'
Expand Down
27 changes: 0 additions & 27 deletions lib/openstudio-standards/hvac_sizing/Siz.AirLoopHVACUnitaryHeatCoolVAVChngByp.rb
View file
Open in desktop

This file was deleted.

69 changes: 0 additions & 69 deletions lib/openstudio-standards/hvac_sizing/Siz.AirLoopHVACUnitaryHeatPumpAirToAir.rb
View file
Open in desktop

This file was deleted.

Loading