Merge from commit eea3c93 #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 524577e.
…e archetype base files" This reverts commit c9664d7.
…odel in the NECB archetypes: 1) Method 'apply_kiva_foundation' goes through the foundation floors and assigns a Kiva model boundary condition. The foundation walls, if any, that are in contact with the ground and the ground floor are also assigned the same Kiva model as the floor. 2) Method 'get_surface_exp_per' is used to find the exposed perimeter of a foundation floor in contact with the ground. 3) Method 'replace_massless_material_with_std_material' replaces any massless material in the foundation floors and walls with a standard material. This is a requirment for the use of the Kiva model.
…cts created. Use the same Kiva model for as many zones as possible. When a standard construction is created for a surface in contact with ground, reuse this construction throughout the rest of the model.
mdahlhausen
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Looks great @ckirney. I will review apply_kiva_foundation(model) in more detail as I dig into the differences between OSv3.2.1 and OSv3.5.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.