Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break out lights in EMS code #1447

Merged
merged 3 commits into from
Mar 16, 2023
Merged

break out lights in EMS code #1447

merged 3 commits into from
Mar 16, 2023

Conversation

mdahlhausen
Copy link
Collaborator

- clone and assign individual lights objects to each space
- use the space object in E+9.6 / OS v3.3 and higher versions
- hardcode space floor area as a number instead of an internal variable (will need to delete and re-run method if space sizes change)
@lymereJ
Copy link
Collaborator

lymereJ commented Mar 14, 2023

I'll let @leijerry888 review it since he's the author of that method.

@lymereJ lymereJ requested review from leijerry888 and removed request for lymereJ March 14, 2023 23:26
after cloning the space type lights to the individual spaces, delete the lights on the space type objects.

Fixes the issue of having duplicate lights
update 90.1-2016 and 90.1-2019 regression models
Copy link
Collaborator

@leijerry888 leijerry888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt! The rb code changes look good to me!

@mdahlhausen
Copy link
Collaborator Author

Known error in the secondary school prototype in OSv3.2.1:
The tests pass on a windows machine, and fail on a linux machine. Looking into it, but merging anyways b/c it is likely an OpenStudio bug that needs to be addressed, not an openstudio-standards issue.

  test_regression-SecondarySchool-90.1-2016-ASHRAE_169-2013-4A    FAIL (36.48s)
        For OS:Daylighting:Control called 'Aux_Gym_ZN_1_FLR_1 Daylt Sensor 2'  'Position X-Coordinate': true model = '12.0', compare model = '3.0'
        For OS:Daylighting:Control called 'Aux_Gym_ZN_1_FLR_1 Daylt Sensor 2'  'Position Y-Coordinate': true model = '8.65277', compare model = '2.8889'
        For OS:ThermalZone called 'Aux_Gym_ZN_1_FLR_1 ZN'  'Fraction of Zone Controlled by Primary Daylighting Control': true model = '0.999', compare model = '0.5'
        For OS:ThermalZone called 'Aux_Gym_ZN_1_FLR_1 ZN'  'Fraction of Zone Controlled by Secondary Daylighting Control': true model = '0.0', compare model = '0.499'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

90.1-2016 and 90.1-2019 lighting EMS code
3 participants