Data refactoring #1486
Closed
Data refactoring #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce space types and space type assumptions for 90.1-2004.
Database code migration
* small change to test action * add working directory * ad database code * update yml for action * reformat. * add engine print for action debug * remove byte data * Remove byte from ventilation data * black format * test if code change in osstd would trigger action * add code to prevent action running if no changes in the database folder. * add condition to remove the tests * update script * revise typo * change to a new folder * remove the code chaneg detection * remove needs * Revert changes to Standards.Model and Standards.Space * add python file ignores * Remove pyc files, pip lock file, and other misc files. * File lock is needed for tests. * Move files. * Initial data files. * Remove ids from tables, and temporary remove JSON files. * Black. --------- Co-authored-by: Weili Xu <weili.xu@pnnl.gov>
* Remove IDs from export, fix typos. * Same change but for JSON export. * Fix typos. * Fix typo. * Missing comma * Missing annotation column. * Float formatting * Temporary add JSON files. * Remove initial data folder. * Catch conversion CSV to JSON and JSON to CSV issues.
* Update tests and use logging instead of print. * Correct path
Build test case for the index validation Complete the workflow
Data refactoring l3 validation
* Merge latest changes from dev branch. * Update space type data.
* Misc cleanup * Black formatting * Update JSON files. * Level 1 space type cleanup, add datacenter equipment assumptions. * Add missing tag. * Add missing tag.
* First pass at updating docs. * Update docs. * Update docs. * Update docs. * Update docs. * Update docs. * Update docs.
|
Thanks @lymereJ. I want to wait to merge this until after the release going out this week because it will take a while to review. If that's not ok and you really want it in this release, let's talk. |
|
@mdahlhausen - Oh, totally fine. We should probably have a call to talk about the changes. No rush. |
|
@lymereJ @mdahlhausen just a reminder, the PR removed Jenkins to prevent frequent CI events. Before merge, we should uncomment the lines to allow OpenStudio unit tests. |
…ypes supported by the database.
…-standards into data_refactoring
|
@mdahlhausen - d3c30d7 replaces the standards space types used in the prototype templates. |
|
@weilixu - It looks like the black verification is tripping over a file that's not on that branch. |
move OsLib_Schedules methods from the openstudio-extension-gem to openstudio-standards. Add tests for the new methods.
switch to object methods add yard documentation edits
16 tasks
- remove references to runner and Os_Lib_HelperMethods - add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sets up the new data management process for OpenStudio-Standards. The data management process now relies on a relational database which along some export functionalities enables developers and users of the repository to better track changes to the data, automatically validate data during updates, and maintain important relationship across different interdependent data tables (constructions/materials, space type assumptions, etc.). This provides a more sustainable data management approach and make it easier to expand upon (i.e., add data for additional building energy code; currently the database only covers ASHRAE 90.1-2004 through 2019).
This data refactoring effort also includes a refactoring of the space type data itself. Previously, space type data was defined as a function of building energy code version and building type which based on stakeholder surveys seemed confusing and complicated. The space type data has now been simplified and streamlined. The database offers users and developers a curated (concise yet exhaustive) list of space type to choose from. These space types and associated assumptions can be used to represent most space types in commercial building built in the U.S.
A documentation of the new data management process is provided here.
We expect this PR to stay open and serve as a reference for the upcoming workflow refactoring. We expect to have to provide modification to some of the proposed changes to accommodate changes to the workflow.
A few notes about the changes: