Incorporating nrcan branch changes, udpating NRCan regression test expected results

lib/openstudio-standards/standards/necb/BTAPPRE1980/hvac_systems.rb

@@ -201,12 +201,15 @@ def replace_compressor_name(chiller:, comp_type:, chillers:)
     new_name = chiller_name
     # Go through each chiller compressor type from the chiller table and see if it is in the chiller name.  If it is,
     # then replace the old compressor type in the name with the new one.
+    chlr_name_updated = false
     chiller_types.each do |chill_type|
       if chiller_name.include? chill_type['compressor_type']
         new_name = chiller_name.sub(chill_type['compressor_type'], comp_type)
+        chlr_name_updated = true
         break
       end
     end
+    new_name = chiller_name + ' ' + comp_type if !chlr_name_updated
     chiller.setName(new_name)
     return chiller
   end

lib/openstudio-standards/standards/necb/ECMS/data/chiller_types.json

@@ -0,0 +1,25 @@
+{
+  "tables": {
+    "chiller_types_ecm": {
+      "refs": [
+        "assumption"
+      ],
+      "table": [
+        {
+          "cooling_type": "AirCooled",
+          "compressor_type": "Scroll",
+          "minimum_capacity": 0.0,
+          "maximum_capacity": 150.0,
+          "notes": "Chiller type set based on survey of major chiller manufacturers data"
+        },
+        {
+          "cooling_type": "AirCooled",
+          "compressor_type": "Rotary Screw",
+          "minimum_capacity": 150.0,
+          "maximum_capacity": 9999.0,
+          "notes": "Chiller type set based on survey of major chiller manufacturers data"
+        }
+      ]
+    }
+  }
+}

lib/openstudio-standards/standards/necb/ECMS/data/chillers.json

@@ -0,0 +1,44 @@
+{
+  "tables": {
+    "chillers_ecm": {
+      "refs": [
+        "assumption"
+      ],
+      "table": [
+        {
+          "name": "NECB2020_AirCooledChiller",
+          "compressor_type": "Scroll",
+          "minimum_capacity": 0.0,
+          "maximum_capacity": 9999.0,
+          "minimum_coefficient_of_performance_cooling": 2.866,
+          "capft": "AirCooled_Scroll_CAPFT_NECB2011",
+          "eirft": "AirCooled_Scroll_EIRFT_NECB2011",
+          "eirfplr": "AirCooled_Scroll_EIRFPLR_NECB2011",
+          "notes": "NECB 2020 Table 5.2.12.1.-K Air Cooled Chiller COP. Capacity in ton."
+        },
+        {
+          "name": "NECB2020_AirCooledChiller",
+          "compressor_type": "Reciprocating",
+          "minimum_capacity": 0.0,
+          "maximum_capacity": 9999.0,
+          "minimum_coefficient_of_performance_cooling": 2.866,
+          "capft": "AirCooled_Reciprocating_CAPFT_NECB2011",
+          "eirft": "AirCooled_Reciprocating_EIRFT_NECB2011",
+          "eirfplr": "AirCooled_Reciprocating_EIRFPLR_NECB2011",
+          "notes": "NECB 2020 Table 5.2.12.1.-K Air Cooled Chiller COP. Capacity in ton."
+        },
+        {
+          "name": "NECB2020_AirCooledChiller",
+          "compressor_type": "Screw",
+          "minimum_capacity": 0.0,
+          "maximum_capacity": 9999.0,
+          "minimum_coefficient_of_performance_cooling": 2.866,
+          "capft": "AirCooled_Screw_CAPFT_NECB2011",
+          "eirft": "AirCooled_Screw_EIRFT_NECB2011",
+          "eirfplr": "AirCooled_Screw_EIRFPLR_NECB2011",
+          "notes": "NECB 2020 Table 5.2.12.1.-K Air Cooled Chiller COP. Capacity in ton."
+        }
+      ]
+    }
+  }
+}

lib/openstudio-standards/standards/necb/ECMS/data/curves.json

@@ -2314,6 +2314,231 @@
           "minimum_dependent_variable_output": 0.0,
           "maximum_dependent_variable_output": 38.0,
           "notes": "EnergyPlus sample heating power curve for water to water heat pumps"
+        },
+        {
+          "name": "AirCooled_Scroll_CAPFT_NECB2011",
+          "category": "Electric Chiller",
+          "form": "BiQuadratic",
+          "dependent_variable": "EIRRatio",
+          "independent_variable_1": "Tchws",
+          "independent_variable_2": "Toadb",
+          "coeff_1": 1.02165E+00,
+          "coeff_2": 3.70440E-02,
+          "coeff_3": 2.33248E-04,
+          "coeff_4": -3.89398E-03,
+          "coeff_5": -6.52536E-05,
+          "coeff_6": -2.68045E-04,
+          "coeff_7": null,
+          "coeff_8": null,
+          "coeff_9": null,
+          "coeff_10": null,
+          "minimum_independent_variable_1": 5.0,
+          "maximum_independent_variable_1": 10.0,
+          "minimum_independent_variable_2": 24.0,
+          "maximum_independent_variable_2": 35.0,
+          "minimum_dependent_variable_output": null,
+          "maximum_dependent_variable_output": null,
+          "notes": "From NECB 2011 Table 8.4.4.21.-C (6) for air cooled scroll chiller.  Converted coefficients for deg. F to deg. C."
+        },
+        {
+          "name": "AirCooled_Scroll_EIRFT_NECB2011",
+          "category": "Electric Chiller",
+          "form": "BiQuadratic",
+          "dependent_variable": "EIRRatio",
+          "independent_variable_1": "Tchws",
+          "independent_variable_2": "Toadb",
+          "coeff_1": 7.01818E-01,
+          "coeff_2": -4.52340E-03,
+          "coeff_3": 5.32980E-04,
+          "coeff_4": -5.49468E-03,
+          "coeff_5": 5.44644E-04,
+          "coeff_6": -7.29E-04,
+          "coeff_7": null,
+          "coeff_8": null,
+          "coeff_9": null,
+          "coeff_10": null,
+          "minimum_independent_variable_1": 5.0,
+          "maximum_independent_variable_1": 10.0,
+          "minimum_independent_variable_2": 24.0,
+          "maximum_independent_variable_2": 35.0,
+          "minimum_dependent_variable_output": null,
+          "maximum_dependent_variable_output": null,
+          "notes": "From NECB 2011 Table 8.4.4.21.-C (6) for air cooled scroll chiller.  Converted coefficients for deg. F to deg. C."
+        },
+        {
+          "name": "AirCooled_Scroll_EIRFPLR_NECB2011",
+          "category": "Electric Chiller",
+          "form": "Quadratic",
+          "dependent_variable": "EIRRatio",
+          "independent_variable_1": "QRatio",
+          "independent_variable_2": null,
+          "coeff_1": 0.06369119,
+          "coeff_2": 0.58488832,
+          "coeff_3": 0.35280274,
+          "coeff_4": null,
+          "coeff_5": null,
+          "coeff_6": null,
+          "coeff_7": null,
+          "coeff_8": null,
+          "coeff_9": null,
+          "coeff_10": null,
+          "minimum_independent_variable_1": 0.0,
+          "maximum_independent_variable_1": 1.0,
+          "minimum_independent_variable_2": null,
+          "maximum_independent_variable_2": null,
+          "minimum_dependent_variable_output": null,
+          "maximum_dependent_variable_output": null,
+          "notes": "From NECB 2011 Table 8.4.4.21.-C (4) for air cooled scroll chiller."
+        },
+        {
+          "name": "AirCooled_Reciprocating_CAPFT_NECB2011",
+          "category": "Electric Chiller",
+          "form": "BiQuadratic",
+          "dependent_variable": "EIRRatio",
+          "independent_variable_1": "Tchws",
+          "independent_variable_2": "Toadb",
+          "coeff_1": 1.12619E+00,
+          "coeff_2": 4.15536E-02,
+          "coeff_3": 2.51716E-04,
+          "coeff_4": -1.04924E-02,
+          "coeff_5": 1.01088E-05,
+          "coeff_6": -2.55E-04,
+          "coeff_7": null,
+          "coeff_8": null,
+          "coeff_9": null,
+          "coeff_10": null,
+          "minimum_independent_variable_1": 5.0,
+          "maximum_independent_variable_1": 10.0,
+          "minimum_independent_variable_2": 24.0,
+          "maximum_independent_variable_2": 35.0,
+          "minimum_dependent_variable_output": null,
+          "maximum_dependent_variable_output": null,
+          "notes": "From NECB 2011 Table 8.4.4.21.-C (6) for air cooled reciprocating chiller.  Converted coefficients for deg. F to deg. C."
+        },
+        {
+          "name": "AirCooled_Reciprocating_EIRFT_NECB2011",
+          "category": "Electric Chiller",
+          "form": "BiQuadratic",
+          "dependent_variable": "EIRRatio",
+          "independent_variable_1": "Tchws",
+          "independent_variable_2": "Toadb",
+          "coeff_1": 5.42481E-01,
+          "coeff_2": -1.38816E-02,
+          "coeff_3": 4.77576E-04,
+          "coeff_4": 1.21461E-02,
+          "coeff_5": 1.48100E-04,
+          "coeff_6": -3.35E-04,
+          "coeff_7": null,
+          "coeff_8": null,
+          "coeff_9": null,
+          "coeff_10": null,
+          "minimum_independent_variable_1": 5.0,
+          "maximum_independent_variable_1": 10.0,
+          "minimum_independent_variable_2": 24.0,
+          "maximum_independent_variable_2": 35.0,
+          "minimum_dependent_variable_output": null,
+          "maximum_dependent_variable_output": null,
+          "notes": "From NECB 2011 Table 8.4.4.21.-C (6) for water cooled reciprocating chiller.  Converted coefficients for deg. F to deg. C."
+        },
+        {
+          "name": "AirCooled_Reciprocating_EIRFPLR_NECB2011",
+          "category": "Electric Chiller",
+          "form": "Quadratic",
+          "dependent_variable": "EIRRatio",
+          "independent_variable_1": "QRatio",
+          "independent_variable_2": null,
+          "coeff_1": 0.1143742,
+          "coeff_2": 0.5459334,
+          "coeff_3": 0.34229861,
+          "coeff_4": null,
+          "coeff_5": null,
+          "coeff_6": null,
+          "coeff_7": null,
+          "coeff_8": null,
+          "coeff_9": null,
+          "coeff_10": null,
+          "minimum_independent_variable_1": 0.0,
+          "maximum_independent_variable_1": 1.0,
+          "minimum_independent_variable_2": null,
+          "maximum_independent_variable_2": null,
+          "minimum_dependent_variable_output": null,
+          "maximum_dependent_variable_output": null,
+          "notes": "From NECB 2011 Table 8.4.4.21.-C (4) for air cooled reciprocating chiller."
+        },
+        {
+          "name": "AirCooled_Screw_CAPFT_NECB2011",
+          "category": "Electric Chiller",
+          "form": "BiQuadratic",
+          "dependent_variable": "EIRRatio",
+          "independent_variable_1": "Tchws",
+          "independent_variable_2": "Toadb",
+          "coeff_1": 9.86540E-01,
+          "coeff_2": 4.95029E-02,
+          "coeff_3": -2.98242E-04,
+          "coeff_4": -3.68496E-03,
+          "coeff_5": -4.45500E-05,
+          "coeff_6": -5.01E-04,
+          "coeff_7": null,
+          "coeff_8": null,
+          "coeff_9": null,
+          "coeff_10": null,
+          "minimum_independent_variable_1": 5.0,
+          "maximum_independent_variable_1": 10.0,
+          "minimum_independent_variable_2": 24.0,
+          "maximum_independent_variable_2": 35.0,
+          "minimum_dependent_variable_output": null,
+          "maximum_dependent_variable_output": null,
+          "notes": "From NECB 2011 Table 8.4.4.21.-C (6) for air cooled scroll chiller.  Converted coefficients for deg. F to deg. C."
+        },
+        {
+          "name": "AirCooled_Screw_EIRFT_NECB2011",
+          "category": "Electric Chiller",
+          "form": "BiQuadratic",
+          "dependent_variable": "EIRRatio",
+          "independent_variable_1": "Tchws",
+          "independent_variable_2": "Toadb",
+          "coeff_1": 4.49672E-01,
+          "coeff_2": 1.20074E-02,
+          "coeff_3": -5.21964E-04,
+          "coeff_4": 1.94400E-05,
+          "coeff_5": 4.20876E-04,
+          "coeff_6": -6.02E-04,
+          "coeff_7": null,
+          "coeff_8": null,
+          "coeff_9": null,
+          "coeff_10": null,
+          "minimum_independent_variable_1": 5.0,
+          "maximum_independent_variable_1": 10.0,
+          "minimum_independent_variable_2": 24.0,
+          "maximum_independent_variable_2": 35.0,
+          "minimum_dependent_variable_output": null,
+          "maximum_dependent_variable_output": null,
+          "notes": "From NECB 2011 Table 8.4.4.21.-C (6) for air cooled screw chiller. Converted coefficients for deg. F to deg. C."
+        },
+        {
+          "name": "AirCooled_Screw_EIRFPLR_NECB2011",
+          "category": "Electric Chiller",
+          "form": "Quadratic",
+          "dependent_variable": "EIRRatio",
+          "independent_variable_1": "QRatio",
+          "independent_variable_2": null,
+          "coeff_1": 0.03648722,
+          "coeff_2": 0.73474298,
+          "coeff_3": 0.21994748,
+          "coeff_4": null,
+          "coeff_5": null,
+          "coeff_6": null,
+          "coeff_7": null,
+          "coeff_8": null,
+          "coeff_9": null,
+          "coeff_10": null,
+          "minimum_independent_variable_1": 0.0,
+          "maximum_independent_variable_1": 1.0,
+          "minimum_independent_variable_2": null,
+          "maximum_independent_variable_2": null,
+          "minimum_dependent_variable_output": null,
+          "maximum_dependent_variable_output": null,
+          "notes": "From NECB 2011 Table 8.4.4.21.-C (4) for air cooled screw chiller."
         }
       ]
     }

lib/openstudio-standards/standards/necb/ECMS/ecms.rb

@@ -72,7 +72,7 @@ def apply_system_ecm(model:,
                  heating_fuel: primary_heating_fuel)
   end
 
-  def apply_system_efficiencies_ecm(model:, ecm_system_name: nil)
+  def apply_system_efficiencies_ecm(model:, ecm_system_name: nil, template_standard:)
     # Do nothing if nil.
     return if ecm_system_name.nil? || ecm_system_name == 'none' || ecm_system_name == 'NECB_Default' || ecm_system_name.to_s.downcase == 'remove_airloops_add_zone_baseboards'
 
@@ -83,6 +83,6 @@ def apply_system_efficiencies_ecm(model:, ecm_system_name: nil)
     raise("the method #{ecm_apply_eff_method_name} does not exist in the ECM class. Please verify that this should be called.") unless ecm_std.respond_to?(ecm_apply_eff_method_name)
 
     # apply system eff method.
-    ecm_std.send(ecm_apply_eff_method_name, model)
+    ecm_std.send(ecm_apply_eff_method_name, model, template_standard)
   end
 end